* Re: [BUGFIX PATCH] selftests: Fix pthread link option [not found] <157907976750.14189.12829891067375600434.stgit@devnote2> @ 2020-01-15 19:25 ` Alexei Starovoitov 2020-01-15 22:17 ` Masami Hiramatsu 0 siblings, 1 reply; 2+ messages in thread From: Alexei Starovoitov @ 2020-01-15 19:25 UTC (permalink / raw) To: Masami Hiramatsu Cc: Shuah Khan, linux-kselftest, linux-kernel, jaswinder.singh, bpf, daniel On Wed, Jan 15, 2020 at 06:16:07PM +0900, Masami Hiramatsu wrote: > To support pthread correctly, it is better to use -pthread > instead of -lpthread. > > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> > --- > tools/testing/selftests/bpf/Makefile | 2 +- > tools/testing/selftests/membarrier/Makefile | 2 +- > tools/testing/selftests/mqueue/Makefile | 2 +- > tools/testing/selftests/net/Makefile | 4 ++-- > .../testing/selftests/powerpc/benchmarks/Makefile | 4 ++-- > tools/testing/selftests/powerpc/dscr/Makefile | 2 +- > tools/testing/selftests/powerpc/mm/Makefile | 2 +- > tools/testing/selftests/rseq/Makefile | 2 +- > tools/testing/selftests/rtc/Makefile | 2 +- > tools/testing/selftests/seccomp/Makefile | 2 +- > tools/testing/selftests/timers/Makefile | 2 +- > tools/testing/selftests/vm/Makefile | 2 +- > 12 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index e2fd6f8d579c..419f58c53d12 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -22,7 +22,7 @@ CFLAGS += -g -Wall -O2 $(GENFLAGS) -I$(APIDIR) -I$(LIBDIR) -I$(BPFDIR) \ > -I$(GENDIR) -I$(TOOLSDIR) -I$(CURDIR) \ > -Dbpf_prog_load=bpf_prog_test_load \ > -Dbpf_load_program=bpf_test_load_program > -LDLIBS += -lcap -lelf -lrt -lpthread > +LDLIBS += -lcap -lelf -lrt -pthread Please split this bit into separate patch and send it to bpf@vger targeting bpf-next. selftests/bpf are going through a lot of changes and I'd like to avoid any chance of conflicts. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUGFIX PATCH] selftests: Fix pthread link option 2020-01-15 19:25 ` [BUGFIX PATCH] selftests: Fix pthread link option Alexei Starovoitov @ 2020-01-15 22:17 ` Masami Hiramatsu 0 siblings, 0 replies; 2+ messages in thread From: Masami Hiramatsu @ 2020-01-15 22:17 UTC (permalink / raw) To: Alexei Starovoitov Cc: Shuah Khan, linux-kselftest, linux-kernel, jaswinder.singh, bpf, daniel On Wed, 15 Jan 2020 11:25:30 -0800 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote: > On Wed, Jan 15, 2020 at 06:16:07PM +0900, Masami Hiramatsu wrote: > > To support pthread correctly, it is better to use -pthread > > instead of -lpthread. > > > > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> > > --- > > tools/testing/selftests/bpf/Makefile | 2 +- > > tools/testing/selftests/membarrier/Makefile | 2 +- > > tools/testing/selftests/mqueue/Makefile | 2 +- > > tools/testing/selftests/net/Makefile | 4 ++-- > > .../testing/selftests/powerpc/benchmarks/Makefile | 4 ++-- > > tools/testing/selftests/powerpc/dscr/Makefile | 2 +- > > tools/testing/selftests/powerpc/mm/Makefile | 2 +- > > tools/testing/selftests/rseq/Makefile | 2 +- > > tools/testing/selftests/rtc/Makefile | 2 +- > > tools/testing/selftests/seccomp/Makefile | 2 +- > > tools/testing/selftests/timers/Makefile | 2 +- > > tools/testing/selftests/vm/Makefile | 2 +- > > 12 files changed, 14 insertions(+), 14 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > > index e2fd6f8d579c..419f58c53d12 100644 > > --- a/tools/testing/selftests/bpf/Makefile > > +++ b/tools/testing/selftests/bpf/Makefile > > @@ -22,7 +22,7 @@ CFLAGS += -g -Wall -O2 $(GENFLAGS) -I$(APIDIR) -I$(LIBDIR) -I$(BPFDIR) \ > > -I$(GENDIR) -I$(TOOLSDIR) -I$(CURDIR) \ > > -Dbpf_prog_load=bpf_prog_test_load \ > > -Dbpf_load_program=bpf_test_load_program > > -LDLIBS += -lcap -lelf -lrt -lpthread > > +LDLIBS += -lcap -lelf -lrt -pthread > > Please split this bit into separate patch and send it to bpf@vger targeting > bpf-next. selftests/bpf are going through a lot of changes and I'd like to > avoid any chance of conflicts. OK, I'll split it. Thank you, -- Masami Hiramatsu <mhiramat@kernel.org> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <157907976750.14189.12829891067375600434.stgit@devnote2>
2020-01-15 19:25 ` [BUGFIX PATCH] selftests: Fix pthread link option Alexei Starovoitov
2020-01-15 22:17 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox