* [PATCH] libbpf: Install headers as part of make install
@ 2020-05-26 17:46 Nikolay Borisov
2020-05-26 17:58 ` Andrii Nakryiko
2020-05-26 21:14 ` Daniel Borkmann
0 siblings, 2 replies; 3+ messages in thread
From: Nikolay Borisov @ 2020-05-26 17:46 UTC (permalink / raw)
To: ast; +Cc: daniel, andriin, bpf, Nikolay Borisov
Current 'make install' results in only pkg-config and library binaries
being installed. For consistency also install headers as part of
"make install"
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
tools/lib/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index aee7f1a83c77..d02c4d910aad 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -264,7 +264,7 @@ install_pkgconfig: $(PC_FILE)
$(call QUIET_INSTALL, $(PC_FILE)) \
$(call do_install,$(PC_FILE),$(libdir_SQ)/pkgconfig,644)
-install: install_lib install_pkgconfig
+install: install_lib install_pkgconfig install_headers
### Cleaning rules
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libbpf: Install headers as part of make install
2020-05-26 17:46 [PATCH] libbpf: Install headers as part of make install Nikolay Borisov
@ 2020-05-26 17:58 ` Andrii Nakryiko
2020-05-26 21:14 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2020-05-26 17:58 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf
On Tue, May 26, 2020 at 10:49 AM Nikolay Borisov <nborisov@suse.com> wrote:
>
> Current 'make install' results in only pkg-config and library binaries
> being installed. For consistency also install headers as part of
> "make install"
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
Github Makefile already does that, curiously :)
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/lib/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index aee7f1a83c77..d02c4d910aad 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -264,7 +264,7 @@ install_pkgconfig: $(PC_FILE)
> $(call QUIET_INSTALL, $(PC_FILE)) \
> $(call do_install,$(PC_FILE),$(libdir_SQ)/pkgconfig,644)
>
> -install: install_lib install_pkgconfig
> +install: install_lib install_pkgconfig install_headers
>
> ### Cleaning rules
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libbpf: Install headers as part of make install
2020-05-26 17:46 [PATCH] libbpf: Install headers as part of make install Nikolay Borisov
2020-05-26 17:58 ` Andrii Nakryiko
@ 2020-05-26 21:14 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2020-05-26 21:14 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: ast, andriin, bpf
On Tue, May 26, 2020 at 08:46:12PM +0300, Nikolay Borisov wrote:
> Current 'make install' results in only pkg-config and library binaries
> being installed. For consistency also install headers as part of
> "make install"
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-26 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-26 17:46 [PATCH] libbpf: Install headers as part of make install Nikolay Borisov
2020-05-26 17:58 ` Andrii Nakryiko
2020-05-26 21:14 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox