* [PATCH bpf] bpf: remove inline from bpf_do_trace_printk
@ 2020-08-06 18:26 Stanislav Fomichev
2020-08-06 23:55 ` Alexei Starovoitov
0 siblings, 1 reply; 2+ messages in thread
From: Stanislav Fomichev @ 2020-08-06 18:26 UTC (permalink / raw)
To: netdev, bpf; +Cc: davem, ast, daniel, Stanislav Fomichev
I get the following error during compilation on my side:
kernel/trace/bpf_trace.c: In function 'bpf_do_trace_printk':
kernel/trace/bpf_trace.c:386:34: error: function 'bpf_do_trace_printk' can never be inlined because it uses variable argument lists
static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
^
Fixes: ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
kernel/trace/bpf_trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index cb91ef902cc4..a8d4f253ed77 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -383,7 +383,7 @@ static DEFINE_RAW_SPINLOCK(trace_printk_lock);
#define BPF_TRACE_PRINTK_SIZE 1024
-static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
+static __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
{
static char buf[BPF_TRACE_PRINTK_SIZE];
unsigned long flags;
--
2.28.0.236.gb10cc79966-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH bpf] bpf: remove inline from bpf_do_trace_printk
2020-08-06 18:26 [PATCH bpf] bpf: remove inline from bpf_do_trace_printk Stanislav Fomichev
@ 2020-08-06 23:55 ` Alexei Starovoitov
0 siblings, 0 replies; 2+ messages in thread
From: Alexei Starovoitov @ 2020-08-06 23:55 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: Network Development, bpf, David S. Miller, Alexei Starovoitov,
Daniel Borkmann
On Thu, Aug 6, 2020 at 11:26 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> I get the following error during compilation on my side:
> kernel/trace/bpf_trace.c: In function 'bpf_do_trace_printk':
> kernel/trace/bpf_trace.c:386:34: error: function 'bpf_do_trace_printk' can never be inlined because it uses variable argument lists
> static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
> ^
>
> Fixes: ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-06 23:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-06 18:26 [PATCH bpf] bpf: remove inline from bpf_do_trace_printk Stanislav Fomichev
2020-08-06 23:55 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox