BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>
Subject: [PATCH bpf-next 0/2] fix a verifier failure with xor
Date: Mon, 24 Aug 2020 23:46:08 -0700	[thread overview]
Message-ID: <20200825064608.2017878-1-yhs@fb.com> (raw)

The bpf selftest test_progs/test_sk_assign failed with llvm11 and llvm12.
The reason is that the verifier did not handle xor operation and generate
very conservative register bound. Patch #1 tries to fix the verifier
issue and Patch #2 added additional tests in selftest test_verifier.

Yonghong Song (2):
  bpf: fix a verifier failure with xor
  selftests/bpf: add verifier tests for xor operation

 kernel/bpf/verifier.c                         |  66 ++++++++
 tools/testing/selftests/bpf/verifier/bounds.c | 146 ++++++++++++++++++
 2 files changed, 212 insertions(+)

-- 
2.24.1


             reply	other threads:[~2020-08-25  6:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25  6:46 Yonghong Song [this message]
2020-08-25  6:46 ` [PATCH bpf-next 1/2] bpf: fix a verifier failure with xor Yonghong Song
2020-08-26  1:58   ` Alexei Starovoitov
2020-08-26  3:36     ` Yonghong Song
2020-08-26 22:06       ` John Fastabend
2020-08-27  5:12         ` Alexei Starovoitov
2020-08-27 18:43           ` John Fastabend
2020-09-01 20:07   ` Andrii Nakryiko
2020-09-02  2:17     ` Yonghong Song
2020-09-02  5:27       ` John Fastabend
2020-09-02  5:43         ` Yonghong Song
2020-09-04  5:29           ` John Fastabend
2020-09-02  9:33       ` Toke Høiland-Jørgensen
2020-09-02 14:21         ` Alexei Starovoitov
2020-09-02 15:01           ` Toke Høiland-Jørgensen
2020-09-02 21:40             ` Alexei Starovoitov
2020-08-25  6:46 ` [PATCH bpf-next 2/2] selftests/bpf: add verifier tests for xor operation Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825064608.2017878-1-yhs@fb.com \
    --to=yhs@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox