BPF List
 help / color / mirror / Atom feed
* [PATCH] btf_encoder: Use better fallback message
@ 2020-11-16 20:24 Jiri Olsa
  2020-11-17 18:09 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 2+ messages in thread
From: Jiri Olsa @ 2020-11-16 20:24 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: dwarves, bpf, Alexei Starovoitov, Andrii Nakryiko, Yonghong Song,
	Hao Luo

Using more suitable fallback message for the case when the
ftrace filter can't be used because of missing symbols.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 btf_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/btf_encoder.c b/btf_encoder.c
index 4f856cfd5577..592b31e2cdc9 100644
--- a/btf_encoder.c
+++ b/btf_encoder.c
@@ -510,7 +510,7 @@ static int collect_symbols(struct btf_elf *btfe, bool collect_percpu_vars)
 			printf("Found %d functions!\n", functions_cnt);
 	} else {
 		if (btf_elf__verbose)
-			printf("vmlinux not detected, falling back to dwarf data\n");
+			printf("ftrace symbols not detected, falling back to DWARF data\n");
 		delete_functions();
 	}
 
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btf_encoder: Use better fallback message
  2020-11-16 20:24 [PATCH] btf_encoder: Use better fallback message Jiri Olsa
@ 2020-11-17 18:09 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-11-17 18:09 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: dwarves, bpf, Alexei Starovoitov, Andrii Nakryiko, Yonghong Song,
	Hao Luo

Em Mon, Nov 16, 2020 at 09:24:58PM +0100, Jiri Olsa escreveu:
> Using more suitable fallback message for the case when the
> ftrace filter can't be used because of missing symbols.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  btf_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/btf_encoder.c b/btf_encoder.c
> index 4f856cfd5577..592b31e2cdc9 100644
> --- a/btf_encoder.c
> +++ b/btf_encoder.c
> @@ -510,7 +510,7 @@ static int collect_symbols(struct btf_elf *btfe, bool collect_percpu_vars)
>  			printf("Found %d functions!\n", functions_cnt);
>  	} else {
>  		if (btf_elf__verbose)
> -			printf("vmlinux not detected, falling back to dwarf data\n");
> +			printf("ftrace symbols not detected, falling back to DWARF data\n");
>  		delete_functions();
>  	}
>  
> -- 
> 2.26.2
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-17 18:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-16 20:24 [PATCH] btf_encoder: Use better fallback message Jiri Olsa
2020-11-17 18:09 ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox