* [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage
@ 2021-06-15 13:57 Wang Hai
2021-06-16 10:55 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2021-06-15 13:57 UTC (permalink / raw)
To: davem, kuba, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh
Cc: bpf, netdev, linux-kernel
xdp_sample_pkts usage() is missing the introduction of the
"-S" option, this patch adds it.
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
samples/bpf/xdp_sample_pkts_user.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c
index 706475e004cb..495e09897bd3 100644
--- a/samples/bpf/xdp_sample_pkts_user.c
+++ b/samples/bpf/xdp_sample_pkts_user.c
@@ -103,7 +103,8 @@ static void usage(const char *prog)
fprintf(stderr,
"%s: %s [OPTS] <ifname|ifindex>\n\n"
"OPTS:\n"
- " -F force loading prog\n",
+ " -F force loading prog\n"
+ " -S use skb-mode\n",
__func__, prog);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage
2021-06-15 13:57 [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage Wang Hai
@ 2021-06-16 10:55 ` Jesper Dangaard Brouer
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2021-06-16 10:55 UTC (permalink / raw)
To: Wang Hai
Cc: brouer, davem, kuba, ast, daniel, hawk, john.fastabend, andrii,
kafai, songliubraving, yhs, kpsingh, bpf, netdev
On Tue, 15 Jun 2021 21:57:24 +0800
Wang Hai <wanghai38@huawei.com> wrote:
> xdp_sample_pkts usage() is missing the introduction of the
> "-S" option, this patch adds it.
>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> samples/bpf/xdp_sample_pkts_user.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default")
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> diff --git a/samples/bpf/xdp_sample_pkts_user.c b/samples/bpf/xdp_sample_pkts_user.c
> index 706475e004cb..495e09897bd3 100644
> --- a/samples/bpf/xdp_sample_pkts_user.c
> +++ b/samples/bpf/xdp_sample_pkts_user.c
> @@ -103,7 +103,8 @@ static void usage(const char *prog)
> fprintf(stderr,
> "%s: %s [OPTS] <ifname|ifindex>\n\n"
> "OPTS:\n"
> - " -F force loading prog\n",
> + " -F force loading prog\n"
> + " -S use skb-mode\n",
> __func__, prog);
> }
>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-15 13:57 [PATCH bpf-next] samples/bpf: Add missing option to xdp_sample_pkts usage Wang Hai
2021-06-16 10:55 ` Jesper Dangaard Brouer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox