* [PATCH bpf-next] selftests/bpf: fix a compilation warning
@ 2021-12-09 5:04 Yonghong Song
2021-12-09 7:06 ` Andrii Nakryiko
2021-12-09 7:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yonghong Song @ 2021-12-09 5:04 UTC (permalink / raw)
To: bpf; +Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann, kernel-team
The following warning is triggered when I used clang compiler
to build the selftest.
/.../prog_tests/btf_dedup_split.c:368:6: warning: variable 'btf2' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!ASSERT_OK(err, "btf_dedup"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/.../prog_tests/btf_dedup_split.c:424:12: note: uninitialized use occurs here
btf__free(btf2);
^~~~
/.../prog_tests/btf_dedup_split.c:368:2: note: remove the 'if' if its condition is always false
if (!ASSERT_OK(err, "btf_dedup"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/.../prog_tests/btf_dedup_split.c:343:25: note: initialize the variable 'btf2' to silence this warning
struct btf *btf1, *btf2;
^
= NULL
Initialize local variable btf2 = NULL and the warning is gone.
Signed-off-by: Yonghong Song <yhs@fb.com>
---
tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c b/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c
index 878a864dae3b..90aac437576d 100644
--- a/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c
+++ b/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c
@@ -340,7 +340,7 @@ static void btf_add_dup_struct_in_cu(struct btf *btf, int start_id)
static void test_split_dup_struct_in_cu()
{
- struct btf *btf1, *btf2;
+ struct btf *btf1, *btf2 = NULL;
int err;
/* generate the base data.. */
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: fix a compilation warning
2021-12-09 5:04 [PATCH bpf-next] selftests/bpf: fix a compilation warning Yonghong Song
@ 2021-12-09 7:06 ` Andrii Nakryiko
2021-12-09 7:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2021-12-09 7:06 UTC (permalink / raw)
To: Yonghong Song
Cc: bpf, Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann,
Kernel Team
On Wed, Dec 8, 2021 at 9:04 PM Yonghong Song <yhs@fb.com> wrote:
>
> The following warning is triggered when I used clang compiler
> to build the selftest.
>
> /.../prog_tests/btf_dedup_split.c:368:6: warning: variable 'btf2' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
> if (!ASSERT_OK(err, "btf_dedup"))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /.../prog_tests/btf_dedup_split.c:424:12: note: uninitialized use occurs here
> btf__free(btf2);
> ^~~~
> /.../prog_tests/btf_dedup_split.c:368:2: note: remove the 'if' if its condition is always false
> if (!ASSERT_OK(err, "btf_dedup"))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /.../prog_tests/btf_dedup_split.c:343:25: note: initialize the variable 'btf2' to silence this warning
> struct btf *btf1, *btf2;
> ^
> = NULL
>
> Initialize local variable btf2 = NULL and the warning is gone.
>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
Added:
Fixes: 9a49afe6f5a5 ("selftests/bpf: Add btf_dedup case with
duplicated structs within CU")
and pushed to bpf-next. Thanks.
> tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c b/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c
> index 878a864dae3b..90aac437576d 100644
> --- a/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c
> +++ b/tools/testing/selftests/bpf/prog_tests/btf_dedup_split.c
> @@ -340,7 +340,7 @@ static void btf_add_dup_struct_in_cu(struct btf *btf, int start_id)
>
> static void test_split_dup_struct_in_cu()
> {
> - struct btf *btf1, *btf2;
> + struct btf *btf1, *btf2 = NULL;
> int err;
>
> /* generate the base data.. */
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: fix a compilation warning
2021-12-09 5:04 [PATCH bpf-next] selftests/bpf: fix a compilation warning Yonghong Song
2021-12-09 7:06 ` Andrii Nakryiko
@ 2021-12-09 7:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-09 7:10 UTC (permalink / raw)
To: Yonghong Song; +Cc: bpf, ast, andrii, daniel, kernel-team
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Wed, 8 Dec 2021 21:04:03 -0800 you wrote:
> The following warning is triggered when I used clang compiler
> to build the selftest.
>
> /.../prog_tests/btf_dedup_split.c:368:6: warning: variable 'btf2' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
> if (!ASSERT_OK(err, "btf_dedup"))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /.../prog_tests/btf_dedup_split.c:424:12: note: uninitialized use occurs here
> btf__free(btf2);
> ^~~~
> /.../prog_tests/btf_dedup_split.c:368:2: note: remove the 'if' if its condition is always false
> if (!ASSERT_OK(err, "btf_dedup"))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /.../prog_tests/btf_dedup_split.c:343:25: note: initialize the variable 'btf2' to silence this warning
> struct btf *btf1, *btf2;
> ^
> = NULL
>
> [...]
Here is the summary with links:
- [bpf-next] selftests/bpf: fix a compilation warning
https://git.kernel.org/bpf/bpf-next/c/b540358e6c4d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-09 7:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-09 5:04 [PATCH bpf-next] selftests/bpf: fix a compilation warning Yonghong Song
2021-12-09 7:06 ` Andrii Nakryiko
2021-12-09 7:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox