From: Lina Wang <lina.wang@mediatek.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
bpf <bpf@vger.kernel.org>,
"Maciej Żenczykowski" <maze@google.com>,
"Willem de Bruijn" <willemb@google.com>,
"Eric Dumazet" <edumazet@google.com>
Subject: Re: [PATCH v3] net: fix wrong network header length
Date: Fri, 18 Feb 2022 10:23:15 +0800 [thread overview]
Message-ID: <20220218022315.2560-1-lina.wang@mediatek.com> (raw)
In-Reply-To: <CAADnVQJEXOOH6--uA7BvFUPmXY42zeOQVweHmaMqkbj_g5TLqA@mail.gmail.com>
On Thu, 2022-02-17 at 09:05 -0800, Alexei Starovoitov wrote:
> On Thu, Feb 17, 2022 at 12:45 AM Paolo Abeni <pabeni@redhat.com>
> wrote:
> > To clarify: Alexei is asking to add a test under:
> >
> > tools/testing/selftests/net/
> >
> > to cover this specific case. You can propbably extend the existing
> > udpgro_fwd.sh.
>
> Exactly.
> I suspect the setup needs a bit more than just iperf udp test.
> Does it need a specific driver and hw?
My hw is Android phone, Android system has improved clatd with bpf. When
clatd starts, cls_bpf_classify will handle ingress packets with bpf progs.
bpf_skb_proto_6_to_4 is used here.
> Can it be reproduced with veth or other virtual netdev?
I am not sure. I have no idea how to verify it in linux system.
> Also commit talks about bpf_skb_proto_6_to_4.
> So that bpf helper has to be somehow involved, but iperf udp test
> says nothing about it.
> Please craft a _complete_ selftest.
Thanks!
next prev parent reply other threads:[~2022-02-18 2:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 7:30 [PATCH v3] net: fix wrong network header length Lina Wang
2022-02-17 3:05 ` Alexei Starovoitov
2022-02-17 7:01 ` Lina Wang
2022-02-17 8:45 ` Paolo Abeni
2022-02-17 17:05 ` Alexei Starovoitov
2022-02-18 2:23 ` Lina Wang [this message]
2022-04-07 9:38 ` Lina Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218022315.2560-1-lina.wang@mediatek.com \
--to=lina.wang@mediatek.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox