From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Subject: [PATCH bpf-next v1 0/6] Fixes for bad PTR_TO_BTF_ID offset
Date: Tue, 1 Mar 2022 12:27:39 +0530 [thread overview]
Message-ID: <20220301065745.1634848-1-memxor@gmail.com> (raw)
This set fixes a bug related to bad var_off being permitted for kfunc call in
case of PTR_TO_BTF_ID, consolidates offset checks for all register types allowed
as helper or kfunc arguments into a common shared helper, and introduces a
couple of other checks to harden the kfunc release logic and prevent future
bugs. Some selftests are also included that fail in absence of these fixes,
serving as demonstration of the issues being fixed.
Kumar Kartikeya Dwivedi (6):
bpf: Add check_func_arg_reg_off function
bpf: Fix PTR_TO_BTF_ID var_off check
bpf: Disallow negative offset in check_ptr_off_reg
bpf: Harden register offset checks for release kfunc
selftests/bpf: Update tests for new errstr
selftests/bpf: Add tests for kfunc register offset checks
include/linux/bpf_verifier.h | 3 +
kernel/bpf/btf.c | 24 ++++--
kernel/bpf/verifier.c | 75 ++++++++++-------
net/bpf/test_run.c | 11 +++
.../selftests/bpf/verifier/bounds_deduction.c | 2 +-
tools/testing/selftests/bpf/verifier/calls.c | 82 +++++++++++++++++++
tools/testing/selftests/bpf/verifier/ctx.c | 8 +-
7 files changed, 167 insertions(+), 38 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-01 6:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 6:57 Kumar Kartikeya Dwivedi [this message]
2022-03-01 6:57 ` [PATCH bpf-next v1 1/6] bpf: Add check_func_arg_reg_off function Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 2/6] bpf: Fix PTR_TO_BTF_ID var_off check Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 3/6] bpf: Disallow negative offset in check_ptr_off_reg Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 4/6] bpf: Harden register offset checks for release kfunc Kumar Kartikeya Dwivedi
2022-03-02 3:20 ` Martin KaFai Lau
2022-03-02 9:42 ` Kumar Kartikeya Dwivedi
2022-03-02 21:56 ` Martin KaFai Lau
2022-03-02 22:30 ` Kumar Kartikeya Dwivedi
2022-03-02 22:44 ` Alexei Starovoitov
2022-03-02 23:00 ` Kumar Kartikeya Dwivedi
2022-03-02 23:17 ` Alexei Starovoitov
2022-03-02 23:29 ` Kumar Kartikeya Dwivedi
2022-03-02 23:39 ` Alexei Starovoitov
2022-03-02 23:31 ` Martin KaFai Lau
2022-03-01 6:57 ` [PATCH bpf-next v1 5/6] selftests/bpf: Update tests for new errstr Kumar Kartikeya Dwivedi
2022-03-02 22:45 ` Alexei Starovoitov
2022-03-02 23:02 ` Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 6/6] selftests/bpf: Add tests for kfunc register offset checks Kumar Kartikeya Dwivedi
2022-03-01 11:40 ` kernel test robot
2022-03-01 11:57 ` Kumar Kartikeya Dwivedi
2022-03-02 22:47 ` Alexei Starovoitov
2022-03-02 23:14 ` Kumar Kartikeya Dwivedi
2022-03-02 23:20 ` Alexei Starovoitov
2022-03-02 23:26 ` Nathan Chancellor
2022-03-02 23:37 ` Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301065745.1634848-1-memxor@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox