* [RFC PATCH v4 0/2] Add capabilities file to securityfs @ 2022-07-25 12:41 Francis Laniel 2022-08-16 21:59 ` Paul Moore 0 siblings, 1 reply; 9+ messages in thread From: Francis Laniel @ 2022-07-25 12:41 UTC (permalink / raw) To: linux-security-module Cc: Casey Schaufler, Eric Biederman, Francis Laniel, Serge Hallyn, James Morris, open list, open list:BPF [MISC] Hi. First, I hope you are fine and the same for your relatives. Capabilities are used to check if a thread can perform a given action [1]. For example, a thread with CAP_BPF set can use the bpf() syscall. Capabilities are used in the container world. In terms of code, several projects related to container maintain code where the capabilities are written alike include/uapi/linux/capability.h [2][3][4][5]. For these projects, their codebase should be updated when a new capability is added to the kernel. Some other projects rely on <sys/capability.h> [6]. In this case, this header file should reflect the capabilities offered by the kernel. The delay between adding a new capability to the kernel and this capability being used by "container stack" software users can be long. Indeed, CAP_BPF was added in a17b53c4a4b5 which was part of v5.8 released in August 2020. Almost 2 years later, none of the "container stack" software authorize using this capability in their last stable release. The only way to use CAP_BPF with moby is to use v22.06.0-beta.0 release which contains a commit enabling CAP_BPF, CAP_PERFMON and CAP_CHECKPOINT_RESTORE [7]. This situation can be easily explained by the following: 1. moby depends on containerd which in turns depends on runc. 2. runc depends on github.com/syndtr/gocapability which is golang package to deal with capabilities. This high number of dependencies explain the delay and the big amount of human work to add support in the "container stack" software for a new capability. A solution to this problem could be to add a way for the userspace to ask the kernel about the capabilities it offers. So, in this series, I added a new file to securityfs: /sys/kernel/security/capabilities. The goal of this file is to be used by "container world" software to know kernel capabilities at run time instead of compile time. The "file" is read-only and its content is the capability number associated with the capability name: root@vm-amd64:~# cat /sys/kernel/security/capabilities 0 CAP_CHOWN 1 CAP_DAC_OVERRIDE ... 40 CAP_CHECKPOINT_RESTORE root@vm-amd64:~# wc -c /sys/kernel/security/capabilities 698 /sys/kernel/security/capabilities So, the "container stack" software just have to read this file to know if they can use the capabilities the user asked for. For example, if user asks for CAP_BPF on kernel 5.8, then this capability will be present in the file and so it can be used. Nonetheless, if the underlying kernel is 5.4, this capability will not be present and so it cannot be used. The kernel already exposes the last capability number under: /proc/sys/kernel/cap_last_cap So, I think there should not be any issue exposing all the capabilities it offers. If there is any, please share it as I do not want to introduce issue with this series. Also, the data exchanged with userspace are less than 700 bytes long which represent 17% of PAGE_SIZE. Note that I am open to any better way for the userspace to ask the kernel for known capabilities. And if you see any way to improve this series please share it as it would increase this contribution quality. Change since: v3: * Use securityfs_create_file() to create securityfs file. v2: * Use a char * for cap_string instead of an array, each line of this char * contains the capability number and its name. * Move the file under /sys/kernel/security instead of /sys/kernel. Francis Laniel (2): capability: Add cap_string. security/inode.c: Add capabilities file. include/uapi/linux/capability.h | 1 + kernel/capability.c | 45 +++++++++++++++++++++++++++++++++ security/inode.c | 16 ++++++++++++ 3 files changed, 62 insertions(+) Best regards and thank you in advance for your reviews. --- [1] man capabilities [2] https://github.com/containerd/containerd/blob/1a078e6893d07fec10a4940a5664fab21d6f7d1e/pkg/cap/cap_linux.go#L135 [3] https://github.com/moby/moby/commit/485cf38d48e7111b3d1f584d5e9eab46a902aabc#diff-2e04625b209932e74c617de96682ed72fbd1bb0d0cb9fb7c709cf47a86b6f9c1 moby relies on containerd code. [4] https://github.com/syndtr/gocapability/blob/42c35b4376354fd554efc7ad35e0b7f94e3a0ffb/capability/enum.go#L47 [5] https://github.com/opencontainers/runc/blob/00f56786bb220b55b41748231880ba0e6380519a/libcontainer/capabilities/capabilities.go#L12 runc relies on syndtr package. [6] https://github.com/containers/crun/blob/fafb556f09e6ffd4690c452ff51856b880c089f1/src/libcrun/linux.c#L35 [7] https://github.com/moby/moby/commit/c1c973e81b0ff36c697fbeabeb5ea7d09566ddc0 -- 2.25.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs 2022-07-25 12:41 [RFC PATCH v4 0/2] Add capabilities file to securityfs Francis Laniel @ 2022-08-16 21:59 ` Paul Moore [not found] ` <4420381.LvFx2qVVIh@pwmachine> 0 siblings, 1 reply; 9+ messages in thread From: Paul Moore @ 2022-08-16 21:59 UTC (permalink / raw) To: Francis Laniel Cc: linux-security-module, Casey Schaufler, Eric Biederman, Serge Hallyn, James Morris, open list, open list:BPF [MISC] On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel <flaniel@linux.microsoft.com> wrote: > Hi. > > First, I hope you are fine and the same for your relatives. Hi Francis :) > A solution to this problem could be to add a way for the userspace to ask the > kernel about the capabilities it offers. > So, in this series, I added a new file to securityfs: > /sys/kernel/security/capabilities. > The goal of this file is to be used by "container world" software to know kernel > capabilities at run time instead of compile time. ... > The kernel already exposes the last capability number under: > /proc/sys/kernel/cap_last_cap I'm not clear on why this patchset is needed, why can't the application simply read from "cap_last_cap" to determine what capabilities the kernel supports? -- paul-moore.com ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <4420381.LvFx2qVVIh@pwmachine>]
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs [not found] ` <4420381.LvFx2qVVIh@pwmachine> @ 2022-08-17 14:52 ` Paul Moore 2022-08-17 15:49 ` Casey Schaufler 0 siblings, 1 reply; 9+ messages in thread From: Paul Moore @ 2022-08-17 14:52 UTC (permalink / raw) To: Francis Laniel Cc: linux-security-module, Casey Schaufler, Eric Biederman, Serge Hallyn, James Morris, open list, open list:BPF [MISC] On Wed, Aug 17, 2022 at 7:53 AM Francis Laniel <flaniel@linux.microsoft.com> wrote: > Le mardi 16 août 2022, 23:59:41 CEST Paul Moore a écrit : > > On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel > > > > <flaniel@linux.microsoft.com> wrote: > > > Hi. > > > > > > First, I hope you are fine and the same for your relatives. > > > > Hi Francis :) > > > > > A solution to this problem could be to add a way for the userspace to ask > > > the kernel about the capabilities it offers. > > > So, in this series, I added a new file to securityfs: > > > /sys/kernel/security/capabilities. > > > The goal of this file is to be used by "container world" software to know > > > kernel capabilities at run time instead of compile time. > > > > ... > > > > > The kernel already exposes the last capability number under: > > > /proc/sys/kernel/cap_last_cap > > > > I'm not clear on why this patchset is needed, why can't the > > application simply read from "cap_last_cap" to determine what > > capabilities the kernel supports? > > When you capabilities with, for example, docker, you will fill capabilities > like this: > docker run --rm --cap-add SYS_ADMIN debian:latest echo foo > As a consequence, the "echo foo" will be run with CAP_SYS_ADMIN set. > > Sadly, each time a new capability is added to the kernel, it means "container > stack" software should add a new string corresponding to the number of the > capabilities [1]. Thanks for clarifying things, I thought you were more concerned about detecting what capabilities the running kernel supported, I didn't realize it was getting a string literal for each supported capability. Unless there is a significant show of support for this - and I'm guessing there isn't due to the lack of comments - I don't think this is something we want to add to the kernel, especially since the kernel doesn't really care about the capabilities' names, it's the number that matters. -- paul-moore.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs 2022-08-17 14:52 ` Paul Moore @ 2022-08-17 15:49 ` Casey Schaufler 2022-08-17 16:10 ` Paul Moore 0 siblings, 1 reply; 9+ messages in thread From: Casey Schaufler @ 2022-08-17 15:49 UTC (permalink / raw) To: Paul Moore, Francis Laniel Cc: linux-security-module, Eric Biederman, Serge Hallyn, James Morris, open list, open list:BPF [MISC], casey On 8/17/2022 7:52 AM, Paul Moore wrote: > On Wed, Aug 17, 2022 at 7:53 AM Francis Laniel > <flaniel@linux.microsoft.com> wrote: >> Le mardi 16 août 2022, 23:59:41 CEST Paul Moore a écrit : >>> On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel >>> >>> <flaniel@linux.microsoft.com> wrote: >>>> Hi. >>>> >>>> First, I hope you are fine and the same for your relatives. >>> Hi Francis :) >>> >>>> A solution to this problem could be to add a way for the userspace to ask >>>> the kernel about the capabilities it offers. >>>> So, in this series, I added a new file to securityfs: >>>> /sys/kernel/security/capabilities. >>>> The goal of this file is to be used by "container world" software to know >>>> kernel capabilities at run time instead of compile time. >>> ... >>> >>>> The kernel already exposes the last capability number under: >>>> /proc/sys/kernel/cap_last_cap >>> I'm not clear on why this patchset is needed, why can't the >>> application simply read from "cap_last_cap" to determine what >>> capabilities the kernel supports? >> When you capabilities with, for example, docker, you will fill capabilities >> like this: >> docker run --rm --cap-add SYS_ADMIN debian:latest echo foo >> As a consequence, the "echo foo" will be run with CAP_SYS_ADMIN set. >> >> Sadly, each time a new capability is added to the kernel, it means "container >> stack" software should add a new string corresponding to the number of the >> capabilities [1]. > Thanks for clarifying things, I thought you were more concerned about > detecting what capabilities the running kernel supported, I didn't > realize it was getting a string literal for each supported capability. > Unless there is a significant show of support for this I believe this could be a significant help in encouraging the use of capabilities. An application that has to know the list of capabilities at compile time but is expected to run unmodified for decades isn't going to be satisfied with cap_last_cap. The best it can do with that is abort, not being able to ask an admin what to do in the presence of a capability that wasn't around before because the name isn't known. On the other hand, it's possible that capabilities are a failure, and that any effort to make them easier to use is pointless. > - and I'm > guessing there isn't due to the lack of comments - I don't think this > is something we want to add to the kernel, especially since the kernel > doesn't really care about the capabilities' names, it's the number > that matters. > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs 2022-08-17 15:49 ` Casey Schaufler @ 2022-08-17 16:10 ` Paul Moore 2022-08-17 16:19 ` Serge E. Hallyn 2022-08-17 16:49 ` Casey Schaufler 0 siblings, 2 replies; 9+ messages in thread From: Paul Moore @ 2022-08-17 16:10 UTC (permalink / raw) To: Casey Schaufler Cc: Francis Laniel, linux-security-module, Eric Biederman, Serge Hallyn, James Morris, open list, open list:BPF [MISC] On Wed, Aug 17, 2022 at 11:50 AM Casey Schaufler <casey@schaufler-ca.com> wrote: > On 8/17/2022 7:52 AM, Paul Moore wrote: > > On Wed, Aug 17, 2022 at 7:53 AM Francis Laniel > > <flaniel@linux.microsoft.com> wrote: > >> Le mardi 16 août 2022, 23:59:41 CEST Paul Moore a écrit : > >>> On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel > >>> > >>> <flaniel@linux.microsoft.com> wrote: > >>>> Hi. > >>>> > >>>> First, I hope you are fine and the same for your relatives. > >>> Hi Francis :) > >>> > >>>> A solution to this problem could be to add a way for the userspace to ask > >>>> the kernel about the capabilities it offers. > >>>> So, in this series, I added a new file to securityfs: > >>>> /sys/kernel/security/capabilities. > >>>> The goal of this file is to be used by "container world" software to know > >>>> kernel capabilities at run time instead of compile time. > >>> ... > >>> > >>>> The kernel already exposes the last capability number under: > >>>> /proc/sys/kernel/cap_last_cap > >>> I'm not clear on why this patchset is needed, why can't the > >>> application simply read from "cap_last_cap" to determine what > >>> capabilities the kernel supports? > >> When you capabilities with, for example, docker, you will fill capabilities > >> like this: > >> docker run --rm --cap-add SYS_ADMIN debian:latest echo foo > >> As a consequence, the "echo foo" will be run with CAP_SYS_ADMIN set. > >> > >> Sadly, each time a new capability is added to the kernel, it means "container > >> stack" software should add a new string corresponding to the number of the > >> capabilities [1]. > > Thanks for clarifying things, I thought you were more concerned about > > detecting what capabilities the running kernel supported, I didn't > > realize it was getting a string literal for each supported capability. > > Unless there is a significant show of support for this > > I believe this could be a significant help in encouraging the use of > capabilities. An application that has to know the list of capabilities > at compile time but is expected to run unmodified for decades isn't > going to be satisfied with cap_last_cap. The best it can do with that > is abort, not being able to ask an admin what to do in the presence of > a capability that wasn't around before because the name isn't known. An application isn't going to be able to deduce the semantic value of a capability based solely on a string value, an integer is just as meaningful in that regard. What might be useful is if the application simply accepts a set of capabilities from the user and then checks those against the maximum supported by the kernel, but once again that doesn't require a string value, it just requires the application taking a set of integers and passing those into the kernel when a capability set is required. I still don't see how adding the capability string names to the kernel is useful here. -- paul-moore.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs 2022-08-17 16:10 ` Paul Moore @ 2022-08-17 16:19 ` Serge E. Hallyn 2022-08-17 16:22 ` Paul Moore 2022-08-17 16:49 ` Casey Schaufler 1 sibling, 1 reply; 9+ messages in thread From: Serge E. Hallyn @ 2022-08-17 16:19 UTC (permalink / raw) To: Paul Moore Cc: Casey Schaufler, Francis Laniel, linux-security-module, Eric Biederman, Serge Hallyn, James Morris, open list, open list:BPF [MISC] On Wed, Aug 17, 2022 at 12:10:25PM -0400, Paul Moore wrote: > On Wed, Aug 17, 2022 at 11:50 AM Casey Schaufler <casey@schaufler-ca.com> wrote: > > On 8/17/2022 7:52 AM, Paul Moore wrote: > > > On Wed, Aug 17, 2022 at 7:53 AM Francis Laniel > > > <flaniel@linux.microsoft.com> wrote: > > >> Le mardi 16 août 2022, 23:59:41 CEST Paul Moore a écrit : > > >>> On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel > > >>> > > >>> <flaniel@linux.microsoft.com> wrote: > > >>>> Hi. > > >>>> > > >>>> First, I hope you are fine and the same for your relatives. > > >>> Hi Francis :) > > >>> > > >>>> A solution to this problem could be to add a way for the userspace to ask > > >>>> the kernel about the capabilities it offers. > > >>>> So, in this series, I added a new file to securityfs: > > >>>> /sys/kernel/security/capabilities. > > >>>> The goal of this file is to be used by "container world" software to know > > >>>> kernel capabilities at run time instead of compile time. > > >>> ... > > >>> > > >>>> The kernel already exposes the last capability number under: > > >>>> /proc/sys/kernel/cap_last_cap > > >>> I'm not clear on why this patchset is needed, why can't the > > >>> application simply read from "cap_last_cap" to determine what > > >>> capabilities the kernel supports? > > >> When you capabilities with, for example, docker, you will fill capabilities > > >> like this: > > >> docker run --rm --cap-add SYS_ADMIN debian:latest echo foo > > >> As a consequence, the "echo foo" will be run with CAP_SYS_ADMIN set. > > >> > > >> Sadly, each time a new capability is added to the kernel, it means "container > > >> stack" software should add a new string corresponding to the number of the > > >> capabilities [1]. > > > Thanks for clarifying things, I thought you were more concerned about > > > detecting what capabilities the running kernel supported, I didn't > > > realize it was getting a string literal for each supported capability. > > > Unless there is a significant show of support for this > > > > I believe this could be a significant help in encouraging the use of > > capabilities. An application that has to know the list of capabilities > > at compile time but is expected to run unmodified for decades isn't > > going to be satisfied with cap_last_cap. The best it can do with that > > is abort, not being able to ask an admin what to do in the presence of > > a capability that wasn't around before because the name isn't known. > > An application isn't going to be able to deduce the semantic value of > a capability based solely on a string value, an integer is just as > meaningful in that regard. What might be useful is if the application Maybe it's important to point out that an integer value capability in kernel will NEVER change its string value (or semantic meaning). The libcap tools like capsh accept integer capabilities, other tools probably should as well. (see man 3 cap_from_text) > simply accepts a set of capabilities from the user and then checks > those against the maximum supported by the kernel, but once again that > doesn't require a string value, it just requires the application > taking a set of integers and passing those into the kernel when a > capability set is required. I still don't see how adding the > capability string names to the kernel is useful here. > > -- > paul-moore.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs 2022-08-17 16:19 ` Serge E. Hallyn @ 2022-08-17 16:22 ` Paul Moore 0 siblings, 0 replies; 9+ messages in thread From: Paul Moore @ 2022-08-17 16:22 UTC (permalink / raw) To: Serge E. Hallyn Cc: Casey Schaufler, Francis Laniel, linux-security-module, Eric Biederman, James Morris, open list, open list:BPF [MISC] On Wed, Aug 17, 2022 at 12:19 PM Serge E. Hallyn <serge@hallyn.com> wrote: > On Wed, Aug 17, 2022 at 12:10:25PM -0400, Paul Moore wrote: > > On Wed, Aug 17, 2022 at 11:50 AM Casey Schaufler <casey@schaufler-ca.com> wrote: > > > On 8/17/2022 7:52 AM, Paul Moore wrote: > > > > On Wed, Aug 17, 2022 at 7:53 AM Francis Laniel > > > > <flaniel@linux.microsoft.com> wrote: > > > >> Le mardi 16 août 2022, 23:59:41 CEST Paul Moore a écrit : > > > >>> On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel > > > >>> > > > >>> <flaniel@linux.microsoft.com> wrote: > > > >>>> Hi. > > > >>>> > > > >>>> First, I hope you are fine and the same for your relatives. > > > >>> Hi Francis :) > > > >>> > > > >>>> A solution to this problem could be to add a way for the userspace to ask > > > >>>> the kernel about the capabilities it offers. > > > >>>> So, in this series, I added a new file to securityfs: > > > >>>> /sys/kernel/security/capabilities. > > > >>>> The goal of this file is to be used by "container world" software to know > > > >>>> kernel capabilities at run time instead of compile time. > > > >>> ... > > > >>> > > > >>>> The kernel already exposes the last capability number under: > > > >>>> /proc/sys/kernel/cap_last_cap > > > >>> I'm not clear on why this patchset is needed, why can't the > > > >>> application simply read from "cap_last_cap" to determine what > > > >>> capabilities the kernel supports? > > > >> When you capabilities with, for example, docker, you will fill capabilities > > > >> like this: > > > >> docker run --rm --cap-add SYS_ADMIN debian:latest echo foo > > > >> As a consequence, the "echo foo" will be run with CAP_SYS_ADMIN set. > > > >> > > > >> Sadly, each time a new capability is added to the kernel, it means "container > > > >> stack" software should add a new string corresponding to the number of the > > > >> capabilities [1]. > > > > Thanks for clarifying things, I thought you were more concerned about > > > > detecting what capabilities the running kernel supported, I didn't > > > > realize it was getting a string literal for each supported capability. > > > > Unless there is a significant show of support for this > > > > > > I believe this could be a significant help in encouraging the use of > > > capabilities. An application that has to know the list of capabilities > > > at compile time but is expected to run unmodified for decades isn't > > > going to be satisfied with cap_last_cap. The best it can do with that > > > is abort, not being able to ask an admin what to do in the presence of > > > a capability that wasn't around before because the name isn't known. > > > > An application isn't going to be able to deduce the semantic value of > > a capability based solely on a string value, an integer is just as > > meaningful in that regard. What might be useful is if the application > > Maybe it's important to point out that an integer value capability in > kernel will NEVER change its string value (or semantic meaning). > > The libcap tools like capsh accept integer capabilities, other tools > probably should as well. (see man 3 cap_from_text) Seems like a reasonable thing to me, I would much prefer that than the approach in this patchset. -- paul-moore.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs 2022-08-17 16:10 ` Paul Moore 2022-08-17 16:19 ` Serge E. Hallyn @ 2022-08-17 16:49 ` Casey Schaufler 2022-08-17 17:19 ` Paul Moore 1 sibling, 1 reply; 9+ messages in thread From: Casey Schaufler @ 2022-08-17 16:49 UTC (permalink / raw) To: Paul Moore Cc: Francis Laniel, linux-security-module, Eric Biederman, Serge Hallyn, James Morris, open list, open list:BPF [MISC], casey On 8/17/2022 9:10 AM, Paul Moore wrote: > On Wed, Aug 17, 2022 at 11:50 AM Casey Schaufler <casey@schaufler-ca.com> wrote: >> On 8/17/2022 7:52 AM, Paul Moore wrote: >>> On Wed, Aug 17, 2022 at 7:53 AM Francis Laniel >>> <flaniel@linux.microsoft.com> wrote: >>>> Le mardi 16 août 2022, 23:59:41 CEST Paul Moore a écrit : >>>>> On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel >>>>> >>>>> <flaniel@linux.microsoft.com> wrote: >>>>>> Hi. >>>>>> >>>>>> First, I hope you are fine and the same for your relatives. >>>>> Hi Francis :) >>>>> >>>>>> A solution to this problem could be to add a way for the userspace to ask >>>>>> the kernel about the capabilities it offers. >>>>>> So, in this series, I added a new file to securityfs: >>>>>> /sys/kernel/security/capabilities. >>>>>> The goal of this file is to be used by "container world" software to know >>>>>> kernel capabilities at run time instead of compile time. >>>>> ... >>>>> >>>>>> The kernel already exposes the last capability number under: >>>>>> /proc/sys/kernel/cap_last_cap >>>>> I'm not clear on why this patchset is needed, why can't the >>>>> application simply read from "cap_last_cap" to determine what >>>>> capabilities the kernel supports? >>>> When you capabilities with, for example, docker, you will fill capabilities >>>> like this: >>>> docker run --rm --cap-add SYS_ADMIN debian:latest echo foo >>>> As a consequence, the "echo foo" will be run with CAP_SYS_ADMIN set. >>>> >>>> Sadly, each time a new capability is added to the kernel, it means "container >>>> stack" software should add a new string corresponding to the number of the >>>> capabilities [1]. >>> Thanks for clarifying things, I thought you were more concerned about >>> detecting what capabilities the running kernel supported, I didn't >>> realize it was getting a string literal for each supported capability. >>> Unless there is a significant show of support for this >> I believe this could be a significant help in encouraging the use of >> capabilities. An application that has to know the list of capabilities >> at compile time but is expected to run unmodified for decades isn't >> going to be satisfied with cap_last_cap. The best it can do with that >> is abort, not being able to ask an admin what to do in the presence of >> a capability that wasn't around before because the name isn't known. > An application isn't going to be able to deduce the semantic value of > a capability based solely on a string value, True, but it can ask someone what to do, and in that case a string is much better than a number: thwonkd: Unknown capability 42 - update thwonkd.conf policy section thwonkd: Unknown capability butter_toast - update thwonkd.conf policy section The thwonkd configuration could be updated to use that capability correctly. Yes, you could look capability 42 up in the system header files, but only if they're installed and there's no guarantee that the header files match the running kernel. That said, I can't think of a case where this would be useful in real life except for systemd and chcap. I can't speak to the container manager proposed, as I don't see containers being deployed with finer granularity than "privileged" or "unprivileged". > an integer is just as > meaningful in that regard. What might be useful is if the application > simply accepts a set of capabilities from the user and then checks > those against the maximum supported by the kernel, but once again that > doesn't require a string value, it just requires the application > taking a set of integers and passing those into the kernel when a > capability set is required. I still don't see how adding the > capability string names to the kernel is useful here. > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v4 0/2] Add capabilities file to securityfs 2022-08-17 16:49 ` Casey Schaufler @ 2022-08-17 17:19 ` Paul Moore 0 siblings, 0 replies; 9+ messages in thread From: Paul Moore @ 2022-08-17 17:19 UTC (permalink / raw) To: Casey Schaufler Cc: Francis Laniel, linux-security-module, Eric Biederman, Serge Hallyn, James Morris, open list, open list:BPF [MISC] On Wed, Aug 17, 2022 at 12:49 PM Casey Schaufler <casey@schaufler-ca.com> wrote: > On 8/17/2022 9:10 AM, Paul Moore wrote: > > On Wed, Aug 17, 2022 at 11:50 AM Casey Schaufler <casey@schaufler-ca.com> wrote: > >> On 8/17/2022 7:52 AM, Paul Moore wrote: > >>> On Wed, Aug 17, 2022 at 7:53 AM Francis Laniel > >>> <flaniel@linux.microsoft.com> wrote: > >>>> Le mardi 16 août 2022, 23:59:41 CEST Paul Moore a écrit : > >>>>> On Mon, Jul 25, 2022 at 8:42 AM Francis Laniel > >>>>> > >>>>> <flaniel@linux.microsoft.com> wrote: > >>>>>> Hi. > >>>>>> > >>>>>> First, I hope you are fine and the same for your relatives. > >>>>> Hi Francis :) > >>>>> > >>>>>> A solution to this problem could be to add a way for the userspace to ask > >>>>>> the kernel about the capabilities it offers. > >>>>>> So, in this series, I added a new file to securityfs: > >>>>>> /sys/kernel/security/capabilities. > >>>>>> The goal of this file is to be used by "container world" software to know > >>>>>> kernel capabilities at run time instead of compile time. > >>>>> ... > >>>>> > >>>>>> The kernel already exposes the last capability number under: > >>>>>> /proc/sys/kernel/cap_last_cap > >>>>> I'm not clear on why this patchset is needed, why can't the > >>>>> application simply read from "cap_last_cap" to determine what > >>>>> capabilities the kernel supports? > >>>> When you capabilities with, for example, docker, you will fill capabilities > >>>> like this: > >>>> docker run --rm --cap-add SYS_ADMIN debian:latest echo foo > >>>> As a consequence, the "echo foo" will be run with CAP_SYS_ADMIN set. > >>>> > >>>> Sadly, each time a new capability is added to the kernel, it means "container > >>>> stack" software should add a new string corresponding to the number of the > >>>> capabilities [1]. > >>> Thanks for clarifying things, I thought you were more concerned about > >>> detecting what capabilities the running kernel supported, I didn't > >>> realize it was getting a string literal for each supported capability. > >>> Unless there is a significant show of support for this > >> I believe this could be a significant help in encouraging the use of > >> capabilities. An application that has to know the list of capabilities > >> at compile time but is expected to run unmodified for decades isn't > >> going to be satisfied with cap_last_cap. The best it can do with that > >> is abort, not being able to ask an admin what to do in the presence of > >> a capability that wasn't around before because the name isn't known. > > An application isn't going to be able to deduce the semantic value of > > a capability based solely on a string value, > > True, but it can ask someone what to do, and in that case a string is > much better than a number ... If you are asking a user what to do, that user can just as easily look up the capability list to translate numbers to intent. If your security approach requires a user knowing all of the subtle details around a capability based on 10~15 character string, I wish you the best of luck :) -- paul-moore.com ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-08-17 17:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-25 12:41 [RFC PATCH v4 0/2] Add capabilities file to securityfs Francis Laniel
2022-08-16 21:59 ` Paul Moore
[not found] ` <4420381.LvFx2qVVIh@pwmachine>
2022-08-17 14:52 ` Paul Moore
2022-08-17 15:49 ` Casey Schaufler
2022-08-17 16:10 ` Paul Moore
2022-08-17 16:19 ` Serge E. Hallyn
2022-08-17 16:22 ` Paul Moore
2022-08-17 16:49 ` Casey Schaufler
2022-08-17 17:19 ` Paul Moore
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox