From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@kernel.org>,
Dave Marchevsky <davemarchevsky@meta.com>,
Delyan Kratunov <delyank@meta.com>
Subject: Re: [PATCH bpf-next v5 22/25] selftests/bpf: Update spinlock selftest
Date: Wed, 9 Nov 2022 22:02:19 +0530 [thread overview]
Message-ID: <20221109163219.on5vdlzqisy2z7k5@apollo> (raw)
In-Reply-To: <CAEf4BzbpLYCxXe+k4Hq_Dy0GbqKL-70t_ad4-pdqBzdojLp2uA@mail.gmail.com>
On Wed, Nov 09, 2022 at 05:43:34AM IST, Andrii Nakryiko wrote:
> On Mon, Nov 7, 2022 at 3:11 PM Kumar Kartikeya Dwivedi <memxor@gmail.com> wrote:
> >
> > Make updates in preparation for adding more test cases to this selftest:
> > - Convert from CHECK_ to ASSERT macros.
> > - Use BPF skeleton
> > - Fix typo sping -> spin
> > - Rename spinlock.c -> spin_lock.c
> >
> > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
> > ---
> > .../selftests/bpf/prog_tests/spin_lock.c | 46 +++++++++++++++++++
> > .../selftests/bpf/prog_tests/spinlock.c | 45 ------------------
> > .../selftests/bpf/progs/test_spin_lock.c | 4 +-
> > 3 files changed, 48 insertions(+), 47 deletions(-)
> > create mode 100644 tools/testing/selftests/bpf/prog_tests/spin_lock.c
> > delete mode 100644 tools/testing/selftests/bpf/prog_tests/spinlock.c
> >
>
> [...]
>
> > +void test_spinlock(void)
> > +{
> > + struct test_spin_lock *skel;
> > + pthread_t thread_id[4];
> > + int prog_fd, i;
> > + void *ret;
> > +
> > + skel = test_spin_lock__open_and_load();
> > + if (!ASSERT_OK_PTR(skel, "test_spin_lock__open_and_load"))
> > + return;
> > + prog_fd = bpf_program__fd(skel->progs.bpf_spin_lock_test);
> > + for (i = 0; i < 4; i++)
> > + if (!ASSERT_OK(pthread_create(&thread_id[i], NULL,
> > + &spin_lock_thread, &prog_fd), "pthread_create"))
>
> I mean... does that pthread_create() call have to happen inside ASSERT_OK?
>
> err = pthread_create(...)
> if (!ASSERT_OK(err, "pthread_create"))
> goto end;
>
Ack, I'll rewrite it like this.
next prev parent reply other threads:[~2022-11-09 16:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 23:09 [PATCH bpf-next v5 00/25] Local kptrs, BPF linked lists Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 01/25] bpf: Remove BPF_MAP_OFF_ARR_MAX Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 02/25] bpf: Fix copy_map_value, zero_map_value Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 03/25] bpf: Support bpf_list_head in map values Kumar Kartikeya Dwivedi
2022-11-08 23:01 ` Andrii Nakryiko
2022-11-08 23:39 ` Kumar Kartikeya Dwivedi
2022-11-09 0:22 ` Andrii Nakryiko
2022-11-09 1:03 ` Alexei Starovoitov
2022-11-09 16:41 ` Kumar Kartikeya Dwivedi
2022-11-09 23:14 ` Andrii Nakryiko
2022-11-09 23:11 ` Andrii Nakryiko
2022-11-09 23:35 ` Alexei Starovoitov
2022-11-07 23:09 ` [PATCH bpf-next v5 04/25] bpf: Rename RET_PTR_TO_ALLOC_MEM Kumar Kartikeya Dwivedi
2022-11-08 23:08 ` Andrii Nakryiko
2022-11-07 23:09 ` [PATCH bpf-next v5 05/25] bpf: Rename MEM_ALLOC to MEM_RINGBUF Kumar Kartikeya Dwivedi
2022-11-08 23:14 ` Andrii Nakryiko
2022-11-08 23:49 ` Kumar Kartikeya Dwivedi
2022-11-09 0:26 ` Andrii Nakryiko
2022-11-09 1:05 ` Alexei Starovoitov
2022-11-09 22:58 ` Andrii Nakryiko
2022-11-07 23:09 ` [PATCH bpf-next v5 06/25] bpf: Introduce local kptrs Kumar Kartikeya Dwivedi
2022-11-08 23:29 ` Andrii Nakryiko
2022-11-09 0:00 ` Kumar Kartikeya Dwivedi
2022-11-09 0:36 ` Andrii Nakryiko
2022-11-09 1:32 ` Alexei Starovoitov
2022-11-09 17:00 ` Kumar Kartikeya Dwivedi
2022-11-09 23:23 ` Andrii Nakryiko
2022-11-09 23:21 ` Andrii Nakryiko
2022-11-07 23:09 ` [PATCH bpf-next v5 07/25] bpf: Recognize bpf_{spin_lock,list_head,list_node} in " Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 08/25] bpf: Verify ownership relationships for user BTF types Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 09/25] bpf: Allow locking bpf_spin_lock in local kptr Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 10/25] bpf: Allow locking bpf_spin_lock global variables Kumar Kartikeya Dwivedi
2022-11-08 23:37 ` Andrii Nakryiko
2022-11-09 0:03 ` Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 11/25] bpf: Allow locking bpf_spin_lock in inner map values Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 12/25] bpf: Rewrite kfunc argument handling Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 13/25] bpf: Drop kfunc bits from btf_check_func_arg_match Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 14/25] bpf: Support constant scalar arguments for kfuncs Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 15/25] bpf: Teach verifier about non-size constant arguments Kumar Kartikeya Dwivedi
2022-11-09 0:05 ` Andrii Nakryiko
2022-11-09 16:29 ` Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 16/25] bpf: Introduce bpf_obj_new Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 17/25] bpf: Introduce bpf_obj_drop Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 18/25] bpf: Permit NULL checking pointer with non-zero fixed offset Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 19/25] bpf: Introduce single ownership BPF linked list API Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 20/25] bpf: Add 'release on unlock' logic for bpf_list_push_{front,back} Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 21/25] selftests/bpf: Add __contains macro to bpf_experimental.h Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 22/25] selftests/bpf: Update spinlock selftest Kumar Kartikeya Dwivedi
2022-11-09 0:13 ` Andrii Nakryiko
2022-11-09 16:32 ` Kumar Kartikeya Dwivedi [this message]
2022-11-07 23:09 ` [PATCH bpf-next v5 23/25] selftests/bpf: Add failure test cases for spin lock pairing Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 24/25] selftests/bpf: Add BPF linked list API tests Kumar Kartikeya Dwivedi
2022-11-07 23:09 ` [PATCH bpf-next v5 25/25] selftests/bpf: Add BTF sanity tests Kumar Kartikeya Dwivedi
2022-11-09 0:18 ` Andrii Nakryiko
2022-11-09 16:33 ` Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109163219.on5vdlzqisy2z7k5@apollo \
--to=memxor@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@meta.com \
--cc=delyank@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox