public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Heng Qi <hengqi@linux.alibaba.com>
To: netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Eric Dumazet <edumazet@google.com>
Subject: [RFC PATCH 1/9] virtio_net: disable the hole mechanism for xdp
Date: Tue, 22 Nov 2022 15:43:40 +0800	[thread overview]
Message-ID: <20221122074348.88601-2-hengqi@linux.alibaba.com> (raw)
In-Reply-To: <20221122074348.88601-1-hengqi@linux.alibaba.com>

XDP core assumes that the frame_size of xdp_buff and the length of
the frag are PAGE_SIZE. But before xdp is set, the length of the prefilled
buffer may exceed PAGE_SIZE, which may cause the processing of xdp to fail,
so we disable the hole mechanism when xdp is loaded.

Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
 drivers/net/virtio_net.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9cce7dec7366..c5046d21b281 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1419,8 +1419,11 @@ static int add_recvbuf_mergeable(struct virtnet_info *vi,
 		/* To avoid internal fragmentation, if there is very likely not
 		 * enough space for another buffer, add the remaining space to
 		 * the current buffer.
+		 * XDP core assumes that frame_size of xdp_buff and the length
+		 * of the frag are PAGE_SIZE, so we disable the hole mechanism.
 		 */
-		len += hole;
+		if (!vi->xdp_enabled)
+			len += hole;
 		alloc_frag->offset += hole;
 	}
 
-- 
2.19.1.6.gb485710b


  reply	other threads:[~2022-11-22  7:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  7:43 [RFC PATCH 0/9] virtio_net: support multi buffer xdp Heng Qi
2022-11-22  7:43 ` Heng Qi [this message]
2022-12-06  5:20   ` [RFC PATCH 1/9] virtio_net: disable the hole mechanism for xdp Jason Wang
2022-12-08  8:20     ` Heng Qi
2022-11-22  7:43 ` [RFC PATCH 2/9] virtio_net: set up xdp for multi buffer packets Heng Qi
2022-12-06  5:29   ` Jason Wang
2022-12-08  8:21     ` Heng Qi
2022-11-22  7:43 ` [RFC PATCH 3/9] virtio_net: update bytes calculation for xdp_frame Heng Qi
2022-12-06  5:31   ` Jason Wang
2022-12-08  8:35     ` Heng Qi
2022-11-22  7:43 ` [RFC PATCH 4/9] virtio_net: remove xdp related info from page_to_skb() Heng Qi
2022-12-06  5:36   ` Jason Wang
2022-12-08  8:23     ` Heng Qi
2022-11-22  7:43 ` [RFC PATCH 5/9] virtio_net: build xdp_buff with multi buffers Heng Qi
2022-12-06  6:14   ` Jason Wang
2022-12-08  8:25     ` Heng Qi
2022-11-22  7:43 ` [RFC PATCH 6/9] virtio_net: construct multi-buffer xdp in mergeable Heng Qi
2022-12-06  6:33   ` Jason Wang
2022-12-08  8:30     ` Heng Qi
2022-12-13  7:08       ` Jason Wang
2022-12-14  8:37         ` Heng Qi
2022-12-16  3:46           ` Jason Wang
2022-12-16  9:42             ` Heng Qi
2022-11-22  7:43 ` [RFC PATCH 7/9] virtio_net: build skb from multi-buffer xdp Heng Qi
2022-11-22  7:43 ` [RFC PATCH 8/9] virtio_net: transmit the " Heng Qi
2022-11-22  7:43 ` [RFC PATCH 9/9] virtio_net: support " Heng Qi
2022-12-06  6:42   ` Jason Wang
2022-12-08  8:31     ` Heng Qi
2022-12-02  4:50 ` [RFC PATCH 0/9] virtio_net: support multi buffer xdp Heng Qi
2022-12-02  5:41   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122074348.88601-2-hengqi@linux.alibaba.com \
    --to=hengqi@linux.alibaba.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox