From: Heng Qi <hengqi@linux.alibaba.com>
To: Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [RFC PATCH 3/9] virtio_net: update bytes calculation for xdp_frame
Date: Thu, 8 Dec 2022 16:35:35 +0800 [thread overview]
Message-ID: <e1f2d723-4810-50c9-409f-d6761600beb8@linux.alibaba.com> (raw)
In-Reply-To: <CACGkMEu_WTLJ4QRJ4_KevGLFAu=L7qgY6zV0McnSsDe2TLRawQ@mail.gmail.com>
在 2022/12/6 下午1:31, Jason Wang 写道:
> On Tue, Nov 22, 2022 at 3:44 PM Heng Qi <hengqi@linux.alibaba.com> wrote:
>> Update relative record value for xdp_frame as basis
>> for multi-buffer xdp transmission.
>>
>> Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
>> Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
Thanks for your energy, you are awesome.
>
> Thanks
>
>> ---
>> drivers/net/virtio_net.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index 8f7d207d58d6..d3e8c63b9c4b 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
>> @@ -658,7 +658,7 @@ static int virtnet_xdp_xmit(struct net_device *dev,
>> if (likely(is_xdp_frame(ptr))) {
>> struct xdp_frame *frame = ptr_to_xdp(ptr);
>>
>> - bytes += frame->len;
>> + bytes += xdp_get_frame_len(frame);
>> xdp_return_frame(frame);
>> } else {
>> struct sk_buff *skb = ptr;
>> @@ -1604,7 +1604,7 @@ static void free_old_xmit_skbs(struct send_queue *sq, bool in_napi)
>> } else {
>> struct xdp_frame *frame = ptr_to_xdp(ptr);
>>
>> - bytes += frame->len;
>> + bytes += xdp_get_frame_len(frame);
>> xdp_return_frame(frame);
>> }
>> packets++;
>> --
>> 2.19.1.6.gb485710b
>>
next prev parent reply other threads:[~2022-12-08 8:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 7:43 [RFC PATCH 0/9] virtio_net: support multi buffer xdp Heng Qi
2022-11-22 7:43 ` [RFC PATCH 1/9] virtio_net: disable the hole mechanism for xdp Heng Qi
2022-12-06 5:20 ` Jason Wang
2022-12-08 8:20 ` Heng Qi
2022-11-22 7:43 ` [RFC PATCH 2/9] virtio_net: set up xdp for multi buffer packets Heng Qi
2022-12-06 5:29 ` Jason Wang
2022-12-08 8:21 ` Heng Qi
2022-11-22 7:43 ` [RFC PATCH 3/9] virtio_net: update bytes calculation for xdp_frame Heng Qi
2022-12-06 5:31 ` Jason Wang
2022-12-08 8:35 ` Heng Qi [this message]
2022-11-22 7:43 ` [RFC PATCH 4/9] virtio_net: remove xdp related info from page_to_skb() Heng Qi
2022-12-06 5:36 ` Jason Wang
2022-12-08 8:23 ` Heng Qi
2022-11-22 7:43 ` [RFC PATCH 5/9] virtio_net: build xdp_buff with multi buffers Heng Qi
2022-12-06 6:14 ` Jason Wang
2022-12-08 8:25 ` Heng Qi
2022-11-22 7:43 ` [RFC PATCH 6/9] virtio_net: construct multi-buffer xdp in mergeable Heng Qi
2022-12-06 6:33 ` Jason Wang
2022-12-08 8:30 ` Heng Qi
2022-12-13 7:08 ` Jason Wang
2022-12-14 8:37 ` Heng Qi
2022-12-16 3:46 ` Jason Wang
2022-12-16 9:42 ` Heng Qi
2022-11-22 7:43 ` [RFC PATCH 7/9] virtio_net: build skb from multi-buffer xdp Heng Qi
2022-11-22 7:43 ` [RFC PATCH 8/9] virtio_net: transmit the " Heng Qi
2022-11-22 7:43 ` [RFC PATCH 9/9] virtio_net: support " Heng Qi
2022-12-06 6:42 ` Jason Wang
2022-12-08 8:31 ` Heng Qi
2022-12-02 4:50 ` [RFC PATCH 0/9] virtio_net: support multi buffer xdp Heng Qi
2022-12-02 5:41 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1f2d723-4810-50c9-409f-d6761600beb8@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox