BPF List
 help / color / mirror / Atom feed
* [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore
@ 2023-03-15  5:49 Greg Thelen
  2023-03-15 21:20 ` John Fastabend
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Greg Thelen @ 2023-03-15  5:49 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Ian Rogers
  Cc: bpf, linux-kernel, Greg Thelen

After building the kernel I see:
  $ git status -s
  ?? tools/bpf/resolve_btfids/libbpf/

Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
started copying header files into
tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
not covered by higher level wildcard gitignores.

gitignore the entire libsubcmd directory. It's created as part of build
and removed by clean.

Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
Signed-off-by: Greg Thelen <gthelen@google.com>
---
 tools/bpf/resolve_btfids/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 16913fffc985..52d5e9721d92 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,3 +1,4 @@
 /fixdep
 /resolve_btfids
 /libbpf/
+/libsubcmd/
-- 
2.40.0.rc1.284.g88254d51c5-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* RE: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore
  2023-03-15  5:49 [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore Greg Thelen
@ 2023-03-15 21:20 ` John Fastabend
  2023-03-15 21:20 ` Ian Rogers
  2023-03-16 21:10 ` Daniel Borkmann
  2 siblings, 0 replies; 4+ messages in thread
From: John Fastabend @ 2023-03-15 21:20 UTC (permalink / raw)
  To: Greg Thelen, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Ian Rogers
  Cc: bpf, linux-kernel, Greg Thelen

Greg Thelen wrote:
> After building the kernel I see:
>   $ git status -s
>   ?? tools/bpf/resolve_btfids/libbpf/
> 
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
> 
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
> 
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <gthelen@google.com>
> ---
>  tools/bpf/resolve_btfids/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> index 16913fffc985..52d5e9721d92 100644
> --- a/tools/bpf/resolve_btfids/.gitignore
> +++ b/tools/bpf/resolve_btfids/.gitignore
> @@ -1,3 +1,4 @@
>  /fixdep
>  /resolve_btfids
>  /libbpf/
> +/libsubcmd/
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
> 

Thanks.

Acked-by: John Fastabend <john.fastabend@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore
  2023-03-15  5:49 [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore Greg Thelen
  2023-03-15 21:20 ` John Fastabend
@ 2023-03-15 21:20 ` Ian Rogers
  2023-03-16 21:10 ` Daniel Borkmann
  2 siblings, 0 replies; 4+ messages in thread
From: Ian Rogers @ 2023-03-15 21:20 UTC (permalink / raw)
  To: Greg Thelen
  Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, bpf,
	linux-kernel

On Tue, Mar 14, 2023 at 10:49 PM Greg Thelen <gthelen@google.com> wrote:
>
> After building the kernel I see:
>   $ git status -s
>   ?? tools/bpf/resolve_btfids/libbpf/
>
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
>
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
>
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <gthelen@google.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks!
Ian

> ---
>  tools/bpf/resolve_btfids/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> index 16913fffc985..52d5e9721d92 100644
> --- a/tools/bpf/resolve_btfids/.gitignore
> +++ b/tools/bpf/resolve_btfids/.gitignore
> @@ -1,3 +1,4 @@
>  /fixdep
>  /resolve_btfids
>  /libbpf/
> +/libsubcmd/
> --
> 2.40.0.rc1.284.g88254d51c5-goog
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore
  2023-03-15  5:49 [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore Greg Thelen
  2023-03-15 21:20 ` John Fastabend
  2023-03-15 21:20 ` Ian Rogers
@ 2023-03-16 21:10 ` Daniel Borkmann
  2 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2023-03-16 21:10 UTC (permalink / raw)
  To: Greg Thelen, Alexei Starovoitov, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Ian Rogers
  Cc: bpf, linux-kernel

On 3/15/23 6:49 AM, Greg Thelen wrote:
> After building the kernel I see:
>    $ git status -s
>    ?? tools/bpf/resolve_btfids/libbpf/
> 
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
> 
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
> 
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <gthelen@google.com>

Already fixed in bpf-next by:

commit fd4cb29f2a3d54ec7b4e012300321601af10bd68
Author: Rong Tao <rongtao@cestc.cn>
Date:   Sat Mar 4 23:17:04 2023 +0800

     tools/resolve_btfids: Add /libsubcmd to .gitignore

Thanks,
Daniel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-16 21:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-15  5:49 [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore Greg Thelen
2023-03-15 21:20 ` John Fastabend
2023-03-15 21:20 ` Ian Rogers
2023-03-16 21:10 ` Daniel Borkmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox