[PATCH bpf-next] veristat: change guess for __sk_buff from CGROUP_SKB to SCHED_CLS

[PATCH bpf-next] veristat: change guess for __sk_buff from CGROUP_SKB to SCHED_CLS

[Andrii Nakryiko]

SCHED_CLS seems to be a better option as a default guess for freplace
programs that have __sk_buff as a context type.

Reported-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
 tools/testing/selftests/bpf/veristat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
index 055df1abd7ca..7888c03ba631 100644
--- a/tools/testing/selftests/bpf/veristat.c
+++ b/tools/testing/selftests/bpf/veristat.c
@@ -798,7 +798,7 @@ static int guess_prog_type_by_ctx_name(const char *ctx_name,
 		enum bpf_attach_type attach_type;
 	} ctx_map[] = {
 		/* __sk_buff is most ambiguous, for now we assume cgroup_skb */
-		{ "__sk_buff", "sk_buff", BPF_PROG_TYPE_CGROUP_SKB, BPF_CGROUP_INET_INGRESS },
+		{ "__sk_buff", "sk_buff", BPF_PROG_TYPE_SCHED_CLS },
 		{ "bpf_sock", "sock", BPF_PROG_TYPE_CGROUP_SOCK, BPF_CGROUP_INET4_POST_BIND },
 		{ "bpf_sock_addr", "bpf_sock_addr_kern",  BPF_PROG_TYPE_CGROUP_SOCK_ADDR, BPF_CGROUP_INET4_BIND },
 		{ "bpf_sock_ops", "bpf_sock_ops_kern", BPF_PROG_TYPE_SOCK_OPS, BPF_CGROUP_SOCK_OPS },
-- 
2.34.1

Re: [PATCH bpf-next] veristat: change guess for __sk_buff from CGROUP_SKB to SCHED_CLS

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Thu, 30 Mar 2023 12:01:15 -0700 you wrote:
> SCHED_CLS seems to be a better option as a default guess for freplace
> programs that have __sk_buff as a context type.
> 
> Reported-by: Eduard Zingerman <eddyz87@gmail.com>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
>  tools/testing/selftests/bpf/veristat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [bpf-next] veristat: change guess for __sk_buff from CGROUP_SKB to SCHED_CLS
    https://git.kernel.org/bpf/bpf-next/c/d816129530e7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html