From: Daniel Borkmann <daniel@iogearbox.net>
To: kuba@kernel.org
Cc: ast@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org,
Daniel Borkmann <daniel@iogearbox.net>,
syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com,
syzbot+b202b7208664142954fa@syzkaller.appspotmail.com,
syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
Subject: [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free
Date: Sat, 22 Jul 2023 01:33:30 +0200 [thread overview]
Message-ID: <20230721233330.5678-1-daniel@iogearbox.net> (raw)
On qdisc destruction, the ingress_destroy() needs to update the correct
entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer.
Therefore, fix the typo.
Fixes: e420bed02507 ("bpf: Add fd-based tcx multi-prog infra with link support")
Reported-by: syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com
Reported-by: syzbot+b202b7208664142954fa@syzkaller.appspotmail.com
Reported-by: syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
net/sched/sch_ingress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c
index 04e886f6cee4..a463a63192c3 100644
--- a/net/sched/sch_ingress.c
+++ b/net/sched/sch_ingress.c
@@ -123,7 +123,7 @@ static void ingress_destroy(struct Qdisc *sch)
if (entry) {
tcx_miniq_set_active(entry, false);
if (!tcx_entry_is_active(entry)) {
- tcx_entry_update(dev, NULL, false);
+ tcx_entry_update(dev, NULL, true);
tcx_entry_free(entry);
}
}
--
2.34.1
next reply other threads:[~2023-07-21 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 23:33 Daniel Borkmann [this message]
2023-07-22 1:40 ` [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free Daniel Borkmann
2023-07-24 10:55 ` Petr Machata
2023-07-24 19:10 ` patchwork-bot+netdevbpf
2023-08-03 11:10 ` Gal Pressman
2023-08-03 23:48 ` Martin KaFai Lau
2023-08-06 13:47 ` Gal Pressman
2023-08-03 23:54 ` Daniel Borkmann
2023-08-06 13:50 ` Gal Pressman
2023-08-04 13:31 ` Ido Schimmel
2023-08-06 13:47 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721233330.5678-1-daniel@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+14736e249bce46091c18@syzkaller.appspotmail.com \
--cc=syzbot+b202b7208664142954fa@syzkaller.appspotmail.com \
--cc=syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox