From: Gal Pressman <gal@nvidia.com>
To: Daniel Borkmann <daniel@iogearbox.net>, kuba@kernel.org
Cc: ast@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org,
syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com,
syzbot+b202b7208664142954fa@syzkaller.appspotmail.com,
syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free
Date: Thu, 3 Aug 2023 14:10:51 +0300 [thread overview]
Message-ID: <bdfc2640-8f65-5b56-4472-db8e2b161aab@nvidia.com> (raw)
In-Reply-To: <20230721233330.5678-1-daniel@iogearbox.net>
On 22/07/2023 2:33, Daniel Borkmann wrote:
> On qdisc destruction, the ingress_destroy() needs to update the correct
> entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer.
> Therefore, fix the typo.
>
> Fixes: e420bed02507 ("bpf: Add fd-based tcx multi-prog infra with link support")
> Reported-by: syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com
> Reported-by: syzbot+b202b7208664142954fa@syzkaller.appspotmail.com
> Reported-by: syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Hi Daniel,
Our nightly regression testing picked up new memory leaks which were
bisected to this commit.
Unfortunately, I do not know the exact repro steps to trigger it, maybe
the attached kmemeleak logs can help?
unreferenced object 0xffff88811ce37b80 (size 224):
comm "kworker/14:1", pid 7451, jiffies 4295350041 (age 64.444s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 e0 69 29 81 88 ff ff 00 3a 39 0d 81 88 ff ff ..i).....:9.....
backtrace:
[<00000000a0f098fe>] __alloc_skb+0x1f4/0x2b0
[<000000000dabee54>] alloc_skb_with_frags+0x7a/0x6c0
[<00000000e681c78a>] sock_alloc_send_pskb+0x63f/0x7d0
[<00000000a4774143>] mld_newpack.isra.0+0x1ad/0x800
[<0000000060e32100>] add_grhead+0x271/0x320
[<00000000040e7099>] add_grec+0xc8b/0x1120
[<000000009853483c>] mld_ifc_work+0x387/0xae0
[<0000000079d8299d>] process_one_work+0x86a/0x1430
[<000000001968010b>] worker_thread+0x5b0/0xf00
[<0000000090c285b0>] kthread+0x2dd/0x3b0
[<000000001f322d79>] ret_from_fork+0x2d/0x70
[<000000008ad6bd7b>] ret_from_fork_asm+0x11/0x20
unreferenced object 0xffff888153058640 (size 224):
comm "softirq", pid 0, jiffies 4295350849 (age 61.212s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 e0 69 29 81 88 ff ff c0 32 39 0d 81 88 ff ff ..i).....29.....
backtrace:
[<00000000a0f098fe>] __alloc_skb+0x1f4/0x2b0
[<00000000bb2ddb4c>] ndisc_alloc_skb+0x133/0x340
[<0000000009614816>] ndisc_send_rs+0x1e0/0x4b0
[<000000004bc1b8be>] addrconf_rs_timer+0x25a/0x720
[<000000004d021706>] call_timer_fn+0x167/0x3d0
[<0000000088aa76a3>] __run_timers.part.0+0x546/0x8b0
[<0000000066f62ff3>] run_timer_softirq+0x6a/0x100
[<000000003732ddfb>] __do_softirq+0x264/0x80c
unreferenced object 0xffff888155d0a500 (size 224):
comm "softirq", pid 0, jiffies 4295352832 (age 53.328s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 e0 69 29 81 88 ff ff c0 32 39 0d 81 88 ff ff ..i).....29.....
backtrace:
[<00000000a0f098fe>] __alloc_skb+0x1f4/0x2b0
[<00000000bb2ddb4c>] ndisc_alloc_skb+0x133/0x340
[<0000000009614816>] ndisc_send_rs+0x1e0/0x4b0
[<000000004bc1b8be>] addrconf_rs_timer+0x25a/0x720
[<000000004d021706>] call_timer_fn+0x167/0x3d0
[<0000000088aa76a3>] __run_timers.part.0+0x546/0x8b0
[<0000000066f62ff3>] run_timer_softirq+0x6a/0x100
[<000000003732ddfb>] __do_softirq+0x264/0x80c
unreferenced object 0xffff88814e3f6040 (size 576):
comm "softirq", pid 0, jiffies 4295352832 (age 53.328s)
hex dump (first 32 bytes):
00 00 33 33 00 00 00 02 e8 eb d3 98 21 bc 86 dd ..33........!...
60 00 00 00 00 10 3a ff fe 80 00 00 00 00 00 00 `.....:.........
backtrace:
[<00000000525ad98b>] kmalloc_reserve+0x118/0x1f0
[<000000008d146183>] __alloc_skb+0x105/0x2b0
[<00000000bb2ddb4c>] ndisc_alloc_skb+0x133/0x340
[<0000000009614816>] ndisc_send_rs+0x1e0/0x4b0
[<000000004bc1b8be>] addrconf_rs_timer+0x25a/0x720
[<000000004d021706>] call_timer_fn+0x167/0x3d0
[<0000000088aa76a3>] __run_timers.part.0+0x546/0x8b0
[<0000000066f62ff3>] run_timer_softirq+0x6a/0x100
[<000000003732ddfb>] __do_softirq+0x264/0x80c
unreferenced object 0xffff88812acdebc0 (size 16):
comm "umount.nfs", pid 11626, jiffies 4295354796 (age 45.472s)
hex dump (first 16 bytes):
73 65 72 76 65 72 2d 32 00 eb cd 2a 81 88 ff ff server-2...*....
backtrace:
[<0000000010fb5130>] __kmalloc_node_track_caller+0x4c/0x170
[<00000000b866a733>] kvasprintf+0xb0/0x130
[<00000000b3564fca>] kasprintf+0xa6/0xd0
[<00000000f01d6cb3>] nfs_sysfs_move_sb_to_server+0x49/0xd0
[<000000009608708f>] nfs_kill_super+0x5f/0x90
[<0000000090d4108b>] deactivate_locked_super+0x80/0x130
[<000000000856aeb1>] cleanup_mnt+0x258/0x370
[<0000000040582e39>] task_work_run+0x12c/0x210
[<00000000378ea041>] exit_to_user_mode_prepare+0x1a0/0x1b0
[<00000000025e63dd>] syscall_exit_to_user_mode+0x19/0x50
[<00000000f34ad3ee>] do_syscall_64+0x4a/0x90
[<000000009d3e2403>] entry_SYSCALL_64_after_hwframe+0x46/0xb0
next prev parent reply other threads:[~2023-08-03 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 23:33 [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free Daniel Borkmann
2023-07-22 1:40 ` Daniel Borkmann
2023-07-24 10:55 ` Petr Machata
2023-07-24 19:10 ` patchwork-bot+netdevbpf
2023-08-03 11:10 ` Gal Pressman [this message]
2023-08-03 23:48 ` Martin KaFai Lau
2023-08-06 13:47 ` Gal Pressman
2023-08-03 23:54 ` Daniel Borkmann
2023-08-06 13:50 ` Gal Pressman
2023-08-04 13:31 ` Ido Schimmel
2023-08-06 13:47 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdfc2640-8f65-5b56-4472-db8e2b161aab@nvidia.com \
--to=gal@nvidia.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+14736e249bce46091c18@syzkaller.appspotmail.com \
--cc=syzbot+b202b7208664142954fa@syzkaller.appspotmail.com \
--cc=syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox