From: Andrei Matei <andreimatei1@gmail.com>
To: bpf@vger.kernel.org
Cc: sunhao.th@gmail.com, andrii.nakryiko@gmail.com,
eddyz87@gmail.com, Andrei Matei <andreimatei1@gmail.com>
Subject: [PATCH bpf v5 0/3] bpf: fix accesses to uninit stack slots
Date: Thu, 7 Dec 2023 22:25:16 -0500 [thread overview]
Message-ID: <20231208032519.260451-1-andreimatei1@gmail.com> (raw)
Fix two related issues issues around verifying stack accesses:
1. accesses to uninitialized stack memory was allowed inconsistently
2. the maximum stack depth needed for a program was not always
maintained correctly
The two issues are fixed together in one commit because the code for one
affects the other.
V4 to V5:
- target bpf-next (Alexei)
V3 to V4:
- minor fixup to comment in patch 1 (Eduard)
- C89-style in patch 3 (Andrii)
V2 to V3:
- address review comments from Andrii and Eduard
- drop new verifier tests in favor of editing existing tests to check
for stack depth
- append a patch with a bit of cleanup coming out of the previous review
Andrei Matei (3):
bpf: add some comments to stack representation
bpf: fix accesses to uninit stack slots
bpf: minor cleanup around stack bounds
include/linux/bpf_verifier.h | 14 ++++
kernel/bpf/verifier.c | 76 +++++++++----------
tools/testing/selftests/bpf/progs/iters.c | 2 +-
.../selftests/bpf/progs/test_global_func16.c | 2 +-
.../bpf/progs/verifier_basic_stack.c | 8 +-
.../selftests/bpf/progs/verifier_int_ptr.c | 5 +-
.../selftests/bpf/progs/verifier_raw_stack.c | 5 +-
.../selftests/bpf/progs/verifier_var_off.c | 62 ++++++++++++---
.../selftests/bpf/verifier/atomic_cmpxchg.c | 11 ---
tools/testing/selftests/bpf/verifier/calls.c | 4 +-
10 files changed, 115 insertions(+), 74 deletions(-)
--
2.40.1
next reply other threads:[~2023-12-08 3:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 3:25 Andrei Matei [this message]
2023-12-08 3:25 ` [PATCH bpf-next v5 1/3] bpf: add some comments to stack representation Andrei Matei
2023-12-08 21:06 ` Eduard Zingerman
2023-12-08 3:25 ` [PATCH bpf-next v5 2/3] bpf: fix accesses to uninit stack slots Andrei Matei
2023-12-08 3:25 ` [PATCH bpf-next v5 3/3] bpf: minor cleanup around stack bounds Andrei Matei
2023-12-08 21:10 ` Eduard Zingerman
2023-12-08 23:10 ` [PATCH bpf v5 0/3] bpf: fix accesses to uninit stack slots patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208032519.260451-1-andreimatei1@gmail.com \
--to=andreimatei1@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=sunhao.th@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox