BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrei Matei <andreimatei1@gmail.com>, bpf@vger.kernel.org
Cc: sunhao.th@gmail.com, andrii.nakryiko@gmail.com
Subject: Re: [PATCH bpf-next v5 3/3] bpf: minor cleanup around stack bounds
Date: Fri, 08 Dec 2023 23:10:59 +0200	[thread overview]
Message-ID: <f07985f79330ea475c1a6cb2a20b9772e5a65e1e.camel@gmail.com> (raw)
In-Reply-To: <20231208032519.260451-4-andreimatei1@gmail.com>

On Thu, 2023-12-07 at 22:25 -0500, Andrei Matei wrote:
> Push the rounding up of stack offsets into the function responsible for
> growing the stack, rather than relying on all the callers to do it.
> Uncertainty about whether the callers did it or not tripped up people in
> a previous review.
> 
> Signed-off-by: Andrei Matei <andreimatei1@gmail.com>

Acked-by: Eduard Zingerman <eddyz87@gmail.com>

  reply	other threads:[~2023-12-08 21:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  3:25 [PATCH bpf v5 0/3] bpf: fix accesses to uninit stack slots Andrei Matei
2023-12-08  3:25 ` [PATCH bpf-next v5 1/3] bpf: add some comments to stack representation Andrei Matei
2023-12-08 21:06   ` Eduard Zingerman
2023-12-08  3:25 ` [PATCH bpf-next v5 2/3] bpf: fix accesses to uninit stack slots Andrei Matei
2023-12-08  3:25 ` [PATCH bpf-next v5 3/3] bpf: minor cleanup around stack bounds Andrei Matei
2023-12-08 21:10   ` Eduard Zingerman [this message]
2023-12-08 23:10 ` [PATCH bpf v5 0/3] bpf: fix accesses to uninit stack slots patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f07985f79330ea475c1a6cb2a20b9772e5a65e1e.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andreimatei1@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=sunhao.th@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox