* [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst
@ 2024-02-06 4:51 Dave Thaler
2024-02-06 4:51 ` [Bpf] " Dave Thaler
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dave Thaler @ 2024-02-06 4:51 UTC (permalink / raw)
To: bpf; +Cc: bpf, Dave Thaler
* "imm32" should just be "imm"
* Add blank line to fix formatting error reported by Stephen Rothwell [0]
[0]: https://lore.kernel.org/bpf/20240206153301.4ead0bad@canb.auug.org.au/T/#u
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
---
Documentation/bpf/standardization/instruction-set.rst | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
index 1c4258f1c..bdfe0cd0e 100644
--- a/Documentation/bpf/standardization/instruction-set.rst
+++ b/Documentation/bpf/standardization/instruction-set.rst
@@ -117,6 +117,7 @@ corresponds to a set of instructions that are mandatory. That is, each
instruction has one or more conformance groups of which it is a member.
This document defines the following conformance groups:
+
* base32: includes all instructions defined in this
specification unless otherwise noted.
* base64: includes base32, plus instructions explicitly noted
@@ -289,11 +290,11 @@ where '(u32)' indicates that the upper 32 bits are zeroed.
``BPF_XOR | BPF_K | BPF_ALU`` means::
- dst = (u32) dst ^ (u32) imm32
+ dst = (u32) dst ^ (u32) imm
``BPF_XOR | BPF_K | BPF_ALU64`` means::
- dst = dst ^ imm32
+ dst = dst ^ imm
Note that most instructions have instruction offset of 0. Only three instructions
(``BPF_SDIV``, ``BPF_SMOD``, ``BPF_MOVSX``) have a non-zero offset.
@@ -511,7 +512,7 @@ instructions that transfer data between a register and memory.
``BPF_MEM | <size> | BPF_ST`` means::
- *(size *) (dst + offset) = imm32
+ *(size *) (dst + offset) = imm
``BPF_MEM | <size> | BPF_LDX`` means::
--
2.40.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Bpf] [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst
2024-02-06 4:51 [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst Dave Thaler
@ 2024-02-06 4:51 ` Dave Thaler
2024-02-06 6:33 ` David Vernet
2024-02-06 15:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Dave Thaler @ 2024-02-06 4:51 UTC (permalink / raw)
To: bpf; +Cc: bpf, Dave Thaler
* "imm32" should just be "imm"
* Add blank line to fix formatting error reported by Stephen Rothwell [0]
[0]: https://lore.kernel.org/bpf/20240206153301.4ead0bad@canb.auug.org.au/T/#u
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
---
Documentation/bpf/standardization/instruction-set.rst | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
index 1c4258f1c..bdfe0cd0e 100644
--- a/Documentation/bpf/standardization/instruction-set.rst
+++ b/Documentation/bpf/standardization/instruction-set.rst
@@ -117,6 +117,7 @@ corresponds to a set of instructions that are mandatory. That is, each
instruction has one or more conformance groups of which it is a member.
This document defines the following conformance groups:
+
* base32: includes all instructions defined in this
specification unless otherwise noted.
* base64: includes base32, plus instructions explicitly noted
@@ -289,11 +290,11 @@ where '(u32)' indicates that the upper 32 bits are zeroed.
``BPF_XOR | BPF_K | BPF_ALU`` means::
- dst = (u32) dst ^ (u32) imm32
+ dst = (u32) dst ^ (u32) imm
``BPF_XOR | BPF_K | BPF_ALU64`` means::
- dst = dst ^ imm32
+ dst = dst ^ imm
Note that most instructions have instruction offset of 0. Only three instructions
(``BPF_SDIV``, ``BPF_SMOD``, ``BPF_MOVSX``) have a non-zero offset.
@@ -511,7 +512,7 @@ instructions that transfer data between a register and memory.
``BPF_MEM | <size> | BPF_ST`` means::
- *(size *) (dst + offset) = imm32
+ *(size *) (dst + offset) = imm
``BPF_MEM | <size> | BPF_LDX`` means::
--
2.40.1
--
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Bpf] [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst
2024-02-06 4:51 [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst Dave Thaler
2024-02-06 4:51 ` [Bpf] " Dave Thaler
@ 2024-02-06 6:33 ` David Vernet
2024-02-06 6:33 ` David Vernet
2024-02-06 15:50 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: David Vernet @ 2024-02-06 6:33 UTC (permalink / raw)
To: Dave Thaler; +Cc: bpf, bpf, Dave Thaler
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
On Mon, Feb 05, 2024 at 08:51:46PM -0800, Dave Thaler wrote:
> * "imm32" should just be "imm"
> * Add blank line to fix formatting error reported by Stephen Rothwell [0]
>
> [0]: https://lore.kernel.org/bpf/20240206153301.4ead0bad@canb.auug.org.au/T/#u
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: David Vernet <void@manifault.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bpf] [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst
2024-02-06 6:33 ` David Vernet
@ 2024-02-06 6:33 ` David Vernet
0 siblings, 0 replies; 5+ messages in thread
From: David Vernet @ 2024-02-06 6:33 UTC (permalink / raw)
To: Dave Thaler; +Cc: bpf, bpf, Dave Thaler
[-- Attachment #1.1: Type: text/plain, Size: 364 bytes --]
On Mon, Feb 05, 2024 at 08:51:46PM -0800, Dave Thaler wrote:
> * "imm32" should just be "imm"
> * Add blank line to fix formatting error reported by Stephen Rothwell [0]
>
> [0]: https://lore.kernel.org/bpf/20240206153301.4ead0bad@canb.auug.org.au/T/#u
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: David Vernet <void@manifault.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 76 bytes --]
--
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst
2024-02-06 4:51 [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst Dave Thaler
2024-02-06 4:51 ` [Bpf] " Dave Thaler
2024-02-06 6:33 ` David Vernet
@ 2024-02-06 15:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-06 15:50 UTC (permalink / raw)
To: Dave Thaler; +Cc: bpf, bpf, dthaler1968
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Mon, 5 Feb 2024 20:51:46 -0800 you wrote:
> * "imm32" should just be "imm"
> * Add blank line to fix formatting error reported by Stephen Rothwell [0]
>
> [0]: https://lore.kernel.org/bpf/20240206153301.4ead0bad@canb.auug.org.au/T/#u
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
>
> [...]
Here is the summary with links:
- [bpf-next] bpf, docs: Fix typos in instructions-set.rst
https://git.kernel.org/bpf/bpf-next/c/563918a0e3af
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-06 15:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-06 4:51 [PATCH bpf-next] bpf, docs: Fix typos in instructions-set.rst Dave Thaler
2024-02-06 4:51 ` [Bpf] " Dave Thaler
2024-02-06 6:33 ` David Vernet
2024-02-06 6:33 ` David Vernet
2024-02-06 15:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox