Re: [PATCH bpf-next] bpf, docs: specify which BPF_ABS and BPF_IND fields were zero

[David Vernet <void@manifault.com>]

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

On Wed, Feb 21, 2024 at 09:54:19AM -0800, Dave Thaler wrote:
> Specifying which fields were unused allows IANA to only list as deprecated
> instructions that were actually used, leaving the rest as unassigned and
> possibly available for future use for something else.
> 
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

Seems reasonable -- guess there's no harm in leaving ourselves the
option of using them in the future.

Acked-by: David Vernet <void@manifault.com>

> ---
>  Documentation/bpf/standardization/instruction-set.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
> index 868d9f617..597a086c8 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -658,6 +658,7 @@ Legacy BPF Packet access instructions
>  BPF previously introduced special instructions for access to packet data that were
>  carried over from classic BPF. These instructions used an instruction
>  class of BPF_LD, a size modifier of BPF_W, BPF_H, or BPF_B, and a
> -mode modifier of BPF_ABS or BPF_IND.  However, these instructions are
> +mode modifier of BPF_ABS or BPF_IND.  The 'dst_reg' and 'offset' fields were
> +set to zero, and 'src_reg' was set to zero for BPF_ABS.  However, these instructions are
>  deprecated and should no longer be used.  All legacy packet access
>  instructions belong to the "legacy" conformance group.
> -- 
> 2.40.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]