From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
bpf@vger.kernel.org, Joel Fernandes <joel@joelfernandes.org>,
Michael Jeanson <mjeanson@efficios.com>
Subject: Re: [PATCH v5 6/8] tracing/bpf-trace: Add support for faultable tracepoints
Date: Tue, 2 Jul 2024 09:02:02 +0900 [thread overview]
Message-ID: <20240702090202.bc000b44890fe16d9b757b40@kernel.org> (raw)
In-Reply-To: <20240626185941.68420-7-mathieu.desnoyers@efficios.com>
On Wed, 26 Jun 2024 14:59:39 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> @@ -2443,9 +2443,15 @@ static int __bpf_probe_register(struct bpf_raw_event_map *btp, struct bpf_prog *
> if (prog->aux->max_tp_access > btp->writable_size)
> return -EINVAL;
>
> - return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func,
> - prog, TRACEPOINT_DEFAULT_PRIO,
> - TRACEPOINT_MAY_EXIST);
> + if (tp->flags & TRACEPOINT_MAY_FAULT) {
> + return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func,
> + prog, TRACEPOINT_DEFAULT_PRIO,
> + TRACEPOINT_MAY_EXIST | TRACEPOINT_MAY_FAULT);
> + } else {
> + return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func,
> + prog, TRACEPOINT_DEFAULT_PRIO,
> + TRACEPOINT_MAY_EXIST);
> + }
nit: you can also just pass the flag directly,
return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func,
prog, TRACEPOINT_DEFAULT_PRIO,
TRACEPOINT_MAY_EXIST | (tp->flags & TRACEPOINT_MAY_FAULT));
But others looks good to me.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thank you,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-07-02 0:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 18:59 [PATCH v5 0/8] Faultable Tracepoints Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 1/8] cleanup.h: Header include guard should match header name Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 2/8] cleanup.h guard: Rename DEFINE_ prefix to DECLARE_ Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 3/8] cleanup.h: Introduce DEFINE_INACTIVE_GUARD and activate_guard Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 4/8] tracing: Introduce faultable tracepoints Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 5/8] tracing/ftrace: Add support for " Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 6/8] tracing/bpf-trace: " Mathieu Desnoyers
2024-07-02 0:02 ` Masami Hiramatsu [this message]
2024-08-28 13:55 ` Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 7/8] tracing/perf: " Mathieu Desnoyers
2024-06-26 18:59 ` [PATCH v5 8/8] tracing: Convert sys_enter/exit to " Mathieu Desnoyers
2024-06-27 1:25 ` [PATCH v5 0/8] Faultable Tracepoints Steven Rostedt
2024-08-28 13:52 ` Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2024-06-27 15:23 Mathieu Desnoyers
2024-06-27 15:23 ` [PATCH v5 6/8] tracing/bpf-trace: Add support for faultable tracepoints Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702090202.bc000b44890fe16d9b757b40@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=joel@joelfernandes.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=mjeanson@efficios.com \
--cc=namhyung@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox