BPF List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	mingo@kernel.org, andrii@kernel.org,
	linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	oleg@redhat.com, jolsa@kernel.org, clm@meta.com,
	bpf <bpf@vger.kernel.org>,
	willy@infradead.org
Subject: Re: [PATCH 00/10] perf/uprobe: Optimize uprobes
Date: Tue, 9 Jul 2024 17:31:32 +0200	[thread overview]
Message-ID: <20240709153132.GR27299@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <445aed81-a845-4f5d-8b20-70eced3ce4f8@paulmck-laptop>

On Tue, Jul 09, 2024 at 07:36:41AM -0700, Paul E. McKenney wrote:

> > Per VMA refcounts or per VMA locks are a complete fail IMO.
> 
> Not even to allow concurrent updates of the address space by different
> threads of a process?

Well, I'm sure it helps some workloads. But for others it is just moving
the problem.

> For me, per-VMA locking's need to RCU-protect the VMA is a good step
> towards permitting RCU-protected scans of the Maple Tree, which then
> gets lockless lookup.

Right, the question is if the VMA lock is required to be stable against
splitting. If that is the case, we're hosed :/

At the time I added a seqcount for that, but I'm also remembering that's
one of the things people complained about for single threaded
performance.

  reply	other threads:[~2024-07-09 15:31 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240708091241.544262971@infradead.org>
     [not found] ` <20240709075651.122204f1358f9f78d1e64b62@kernel.org>
2024-07-09  0:25   ` [PATCH 00/10] perf/uprobe: Optimize uprobes Andrii Nakryiko
2024-07-09  9:01     ` Peter Zijlstra
2024-07-09 14:11       ` Paul E. McKenney
2024-07-09 14:29         ` Peter Zijlstra
2024-07-09 14:36           ` Paul E. McKenney
2024-07-09 15:31             ` Peter Zijlstra [this message]
2024-07-09 15:56               ` Paul E. McKenney
2024-07-09 16:10           ` Matthew Wilcox
2024-07-09 16:30             ` Matthew Wilcox
2024-07-09 16:57               ` Paul E. McKenney
2024-07-10  9:16             ` Peter Zijlstra
2024-07-10  9:40               ` Peter Zijlstra
2024-07-22 19:09                 ` Suren Baghdasaryan
2024-07-27  0:20                   ` Andrii Nakryiko
2024-07-27  1:29                     ` Suren Baghdasaryan
2024-07-27  3:45                       ` Matthew Wilcox
2024-07-30  3:18                         ` Andrii Nakryiko
2024-07-30 13:10                         ` Peter Zijlstra
2024-07-30 18:10                           ` Suren Baghdasaryan
2024-08-03  5:47                             ` Andrii Nakryiko
2024-08-03  8:53                               ` Peter Zijlstra
2024-08-04 23:22                                 ` Andrii Nakryiko
2024-08-06  4:08                                   ` Andrii Nakryiko
2024-08-06 14:50                                     ` Suren Baghdasaryan
2024-08-06 17:40                                       ` Andrii Nakryiko
2024-08-06 17:44                                         ` Suren Baghdasaryan
2024-08-07  1:36                                     ` Suren Baghdasaryan
2024-08-07  5:13                                       ` Suren Baghdasaryan
2024-08-07 17:49                                         ` Andrii Nakryiko
2024-08-07 18:04                                           ` Suren Baghdasaryan
2024-08-07 18:30                                             ` Andrii Nakryiko
2024-08-07 18:33                                             ` Suren Baghdasaryan
2024-08-08  0:47                                               ` Andrii Nakryiko
2024-07-30 13:46                   ` Peter Zijlstra
2024-07-30 18:16                     ` Suren Baghdasaryan
2024-07-09 16:42         ` Andrii Nakryiko
2024-07-09  9:03     ` Peter Zijlstra
2024-07-09 10:01       ` Jiri Olsa
2024-07-09 10:16         ` Peter Zijlstra
2024-07-09 22:10           ` Masami Hiramatsu
2024-07-10 10:10             ` Peter Zijlstra
2024-07-10 14:56               ` Masami Hiramatsu
2024-07-10 18:40                 ` Andrii Nakryiko
2024-07-11  8:51                   ` Peter Zijlstra
2024-07-11 15:17                     ` Masami Hiramatsu
2024-07-11 15:22                       ` Peter Zijlstra
2024-07-11 17:47                         ` Steven Rostedt
2024-07-11 23:59                           ` Masami Hiramatsu
2024-07-10  0:55       ` Masami Hiramatsu
2024-07-09 21:47     ` Andrii Nakryiko
2024-07-10 10:12       ` Peter Zijlstra
2024-07-10 12:34         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709153132.GR27299@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=clm@meta.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox