* [PATCH bpf] bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test
@ 2024-07-26 18:08 Jiri Olsa
2024-07-26 21:18 ` Yonghong Song
2024-07-30 20:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Olsa @ 2024-07-26 18:08 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko
Cc: bpf, Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo
Fixing ASSERT_OK condition check in uprobe_syscall test,
otherwise we return from test on pipe success.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
index bd8c75b620c2..797de47f8197 100644
--- a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
+++ b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
@@ -253,7 +253,7 @@ static void test_uretprobe_syscall_call(void)
struct uprobe_syscall_executed *skel;
int pid, status, err, go[2], c;
- if (ASSERT_OK(pipe(go), "pipe"))
+ if (!ASSERT_OK(pipe(go), "pipe"))
return;
skel = uprobe_syscall_executed__open_and_load();
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test
2024-07-26 18:08 [PATCH bpf] bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test Jiri Olsa
@ 2024-07-26 21:18 ` Yonghong Song
2024-07-30 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2024-07-26 21:18 UTC (permalink / raw)
To: Jiri Olsa, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko
Cc: bpf, Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo
On 7/26/24 11:08 AM, Jiri Olsa wrote:
> Fixing ASSERT_OK condition check in uprobe_syscall test,
> otherwise we return from test on pipe success.
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf] bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test
2024-07-26 18:08 [PATCH bpf] bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test Jiri Olsa
2024-07-26 21:18 ` Yonghong Song
@ 2024-07-30 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-07-30 20:50 UTC (permalink / raw)
To: Jiri Olsa
Cc: ast, daniel, andrii, bpf, kafai, songliubraving, yhs,
john.fastabend, kpsingh, sdf, haoluo
Hello:
This patch was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Fri, 26 Jul 2024 20:08:47 +0200 you wrote:
> Fixing ASSERT_OK condition check in uprobe_syscall test,
> otherwise we return from test on pipe success.
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [bpf] bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test
https://git.kernel.org/bpf/bpf/c/7764b9622db4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-30 20:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-26 18:08 [PATCH bpf] bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test Jiri Olsa
2024-07-26 21:18 ` Yonghong Song
2024-07-30 20:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox