* [PATCH bpf-next v1] rqspinlock: Adjust return value for queue destruction
@ 2025-11-11 1:38 Kumar Kartikeya Dwivedi
2025-11-12 18:18 ` Amery Hung
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Kartikeya Dwivedi @ 2025-11-11 1:38 UTC (permalink / raw)
To: bpf
Cc: Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann,
Martin KaFai Lau, Eduard Zingerman, kkd, kernel-team
Return -ETIMEDOUT whenever non-head waiters are signalled by head, and fix
oversight in commit 7bd6e5ce5be6 ("rqspinlock: Disable queue destruction for
deadlocks"). We no longer signal on deadlocks.
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
---
kernel/bpf/rqspinlock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/rqspinlock.c b/kernel/bpf/rqspinlock.c
index b94e258bf2b9..3cc23d79a9fc 100644
--- a/kernel/bpf/rqspinlock.c
+++ b/kernel/bpf/rqspinlock.c
@@ -537,7 +537,7 @@ int __lockfunc resilient_queued_spin_lock_slowpath(rqspinlock_t *lock, u32 val)
val = arch_mcs_spin_lock_contended(&node->locked);
if (val == RES_TIMEOUT_VAL) {
- ret = -EDEADLK;
+ ret = -ETIMEDOUT;
goto waitq_timeout;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH bpf-next v1] rqspinlock: Adjust return value for queue destruction
2025-11-11 1:38 [PATCH bpf-next v1] rqspinlock: Adjust return value for queue destruction Kumar Kartikeya Dwivedi
@ 2025-11-12 18:18 ` Amery Hung
0 siblings, 0 replies; 2+ messages in thread
From: Amery Hung @ 2025-11-12 18:18 UTC (permalink / raw)
To: Kumar Kartikeya Dwivedi
Cc: bpf, Alexei Starovoitov, Andrii Nakryiko, Daniel Borkmann,
Martin KaFai Lau, Eduard Zingerman, kkd, kernel-team
On Mon, Nov 10, 2025 at 5:49 PM Kumar Kartikeya Dwivedi
<memxor@gmail.com> wrote:
>
> Return -ETIMEDOUT whenever non-head waiters are signalled by head, and fix
> oversight in commit 7bd6e5ce5be6 ("rqspinlock: Disable queue destruction for
> deadlocks"). We no longer signal on deadlocks.
>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
> ---
> kernel/bpf/rqspinlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/rqspinlock.c b/kernel/bpf/rqspinlock.c
> index b94e258bf2b9..3cc23d79a9fc 100644
> --- a/kernel/bpf/rqspinlock.c
> +++ b/kernel/bpf/rqspinlock.c
> @@ -537,7 +537,7 @@ int __lockfunc resilient_queued_spin_lock_slowpath(rqspinlock_t *lock, u32 val)
>
> val = arch_mcs_spin_lock_contended(&node->locked);
> if (val == RES_TIMEOUT_VAL) {
> - ret = -EDEADLK;
> + ret = -ETIMEDOUT;
Make sense.
Reviewed-by: Amery Hung <ameryhung@gmail.com>
> goto waitq_timeout;
> }
>
> --
> 2.51.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-12 18:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-11 1:38 [PATCH bpf-next v1] rqspinlock: Adjust return value for queue destruction Kumar Kartikeya Dwivedi
2025-11-12 18:18 ` Amery Hung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox