* [PATCH bpf-next] bpf: Remove inclusion of crypto/sha1.h
@ 2026-03-14 20:47 Eric Biggers
2026-03-14 21:06 ` Eric Biggers
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2026-03-14 20:47 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, John Fastabend,
Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
Yonghong Song, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
bpf
Cc: linux-kernel, Eric Biggers
Since commit 603b44162325 ("bpf: Update the bpf_prog_calc_tag to use
SHA256") made kernel/bpf/core.c use only SHA-256 and not SHA-1, the
header <crypto/sha1.h> no longer needs to be included. Remove the
inclusion so that it no longer unnecessarily comes up in searches for
which kernel code is still using the obsolete SHA-1 algorithm.
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
kernel/bpf/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
index 3ece2da55625c..f11ab6f354e2e 100644
--- a/kernel/bpf/core.c
+++ b/kernel/bpf/core.c
@@ -16,11 +16,10 @@
* Andi Kleen - Fix a few bad bugs and races.
* Kris Katterjohn - Added many additional checks in bpf_check_classic()
*/
#include <uapi/linux/btf.h>
-#include <crypto/sha1.h>
#include <linux/filter.h>
#include <linux/skbuff.h>
#include <linux/vmalloc.h>
#include <linux/prandom.h>
#include <linux/bpf.h>
base-commit: 1c9982b4961334c1edb0745a04cabd34bc2de675
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf: Remove inclusion of crypto/sha1.h
2026-03-14 20:47 [PATCH bpf-next] bpf: Remove inclusion of crypto/sha1.h Eric Biggers
@ 2026-03-14 21:06 ` Eric Biggers
0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2026-03-14 21:06 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, John Fastabend,
Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
Yonghong Song, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
bpf
Cc: linux-kernel
On Sat, Mar 14, 2026 at 01:47:34PM -0700, Eric Biggers wrote:
> Since commit 603b44162325 ("bpf: Update the bpf_prog_calc_tag to use
> SHA256") made kernel/bpf/core.c use only SHA-256 and not SHA-1, the
> header <crypto/sha1.h> no longer needs to be included. Remove the
> inclusion so that it no longer unnecessarily comes up in searches for
> which kernel code is still using the obsolete SHA-1 algorithm.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> kernel/bpf/core.c | 1 -
> 1 file changed, 1 deletion(-)
I missed include/linux/filter.h which is related. I'll send a v2.
- Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-14 21:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-14 20:47 [PATCH bpf-next] bpf: Remove inclusion of crypto/sha1.h Eric Biggers
2026-03-14 21:06 ` Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox