Re: [PATCH 1/5] selftests/xsk: Introduce helpers for setting UMEM properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Infinite recursion in test_spec_set_unaligned helper leading to stack overflow
--

commit 48ddf9c071b166e4cce598b12dfc3870867c0fe6
Author: Tushar Vyavahare <tushar.vyavahare@intel.com>

selftests/xsk: Introduce helpers for setting UMEM properties

This commit introduces helper functions to set UMEM properties in the xsk
selftests. This centralizes the setup logic across tests and prepares for
future refactoring.

> diff --git a/tools/testing/selftests/bpf/prog_tests/test_xsk.c b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> index 7950c504ed28..d5cd8f590b25 100644
> --- a/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> +++ b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> @@ -303,6 +303,22 @@ static void test_spec_reset(struct test_spec *test)
>  	__test_spec_init(test, test->ifobj_tx, test->ifobj_rx);
>  }
>  
> +static void test_spec_set_unaligned(struct test_spec *test)
> +{
> +	test_spec_set_unaligned(test);

Does this cause an infinite recursion leading to a stack overflow?

It looks like the helper calls itself instead of actually setting the
umem->unaligned_mode properties for the TX and RX interfaces. I see this
is fixed later in the patch series in commit 71e22f338d62 ("selftests/xsk:
Eliminate umem reference from ifobject"), but it seems it breaks the tests
at this commit.

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260428080317.702124-1-tushar.vyavahare@intel.com?part=1