Re: [PATCH 4/5] selftests/xsk: Use umem_size() helper consistently

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch misses an open-coded calculation of the UMEM size in `testapp_unaligned_inv_desc_4001_frame()`, failing to fulfill the commit message's claim.
--

commit 55b162869fca46ad80bf9c4d74237ed3830d1f8e
Author: Tushar Vyavahare <tushar.vyavahare@intel.com>

selftests/xsk: Use umem_size() helper consistently

This commit replaces the remaining open-coded calculations of the UMEM
size with the umem_size() helper in test_xsk.c to centralize computation.

> diff --git a/tools/testing/selftests/bpf/prog_tests/test_xsk.c b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> index ea229ea446ca..ba4768f83eb6 100644
> --- a/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> +++ b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> @@ -1581,7 +1581,7 @@ static int thread_common_ops(struct test_spec *test, struct ifobject *ifobject)
>  	int ret;
>  	u32 i;
>  
> -	umem_sz = umem->num_frames * umem->frame_size;
> +	umem_sz = umem_size(umem);
>  	mmap_flags = MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE;

Since open-coded calculations are being replaced here, did this miss the
calculation in testapp_unaligned_inv_desc_4001_frame()?

tools/testing/selftests/bpf/prog_tests/test_xsk.c:testapp_unaligned_inv_desc_4001_frame() {
    ...
	page_size = sysconf(_SC_PAGESIZE);
	umem_size = test->ifobj_tx->xsk->umem->num_frames *
		test->ifobj_tx->xsk->umem->frame_size;
	assert(umem_size % page_size > MIN_PKT_SIZE);
    ...
}

Checking the subsequent patch in the series ('selftests/xsk: Introduce
mmap_size in umem struct'), it appears it does not resolve this missed
calculation either.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260428080317.702124-1-tushar.vyavahare@intel.com?part=4