From: Christian Brauner <brauner@kernel.org>
To: Matt Bobrowski <mattbobrowski@google.com>
Cc: Christian Brauner <brauner@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Quan Sun <2022090917019@std.uestc.edu.cn>,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: fix crash in bpf_[set|remove]_dentry_xattr for negative dentries
Date: Mon, 11 May 2026 11:23:09 +0200 [thread overview]
Message-ID: <20260511-anziehen-kringeln-26b280c04ce9@brauner> (raw)
In-Reply-To: <20260430073836.2894001-1-mattbobrowski@google.com>
On Thu, 30 Apr 2026 07:38:36 +0000, Matt Bobrowski wrote:
> bpf_set_dentry_xattr and bpf_remove_dentry_xattr BPF kfuncs attempt to
> lock the inode of the supplied dentry without checking if it is
> NULL. If a negative dentry is passed (e.g. from
> security_inode_create), d_inode(dentry) returns NULL, and
> inode_lock(inode) will cause a NULL pointer dereference.
>
> Trivially fix this by adding a NULL check for inode before attempting
> to lock it, returning -EINVAL if it is NULL.
>
> [...]
Applied to the vfs-7.2.kfunc branch of the vfs/vfs.git tree.
Patches in the vfs-7.2.kfunc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.2.kfunc
[1/1] bpf: fix crash in bpf_[set|remove]_dentry_xattr for negative dentries
https://git.kernel.org/vfs/vfs/c/07410646f6ff
prev parent reply other threads:[~2026-05-11 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 7:38 [PATCH bpf-next v2] bpf: fix crash in bpf_[set|remove]_dentry_xattr for negative dentries Matt Bobrowski
2026-04-30 8:14 ` bot+bpf-ci
2026-05-03 20:26 ` Matt Bobrowski
2026-05-11 9:23 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511-anziehen-kringeln-26b280c04ce9@brauner \
--to=brauner@kernel.org \
--cc=2022090917019@std.uestc.edu.cn \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=jack@suse.cz \
--cc=jolsa@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox