BPF List
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@kernel.org>
To: Jens Remus <jremus@linux.ibm.com>
Cc: sashiko-reviews@lists.linux.dev,
	Dylan Hatch <dylanbhatch@google.com>,
	bpf@vger.kernel.org, Josh Poimboeuf <jpoimboe@kernel.org>,
	Indu Bhagat <ibhagatgnu@gmail.com>
Subject: Re: [PATCH v16 05/20] unwind_user/sframe: Add support for reading .sframe contents
Date: Wed, 27 May 2026 15:49:18 -0400	[thread overview]
Message-ID: <20260527154918.5204c6da@fedora> (raw)
In-Reply-To: <7fa7ea0c-80fb-4a3e-abc9-8f3dbd7968b1@linux.ibm.com>

On Fri, 22 May 2026 11:26:00 +0200
Jens Remus <jremus@linux.ibm.com> wrote:

> Previously (see v15) the code was using user_read_access_begin() and
> user_read_access_end().  IIUC scoped_user_read_access_size() is just
> another mean to express the same and it behaves the same.  So if the
> issue brought up by Sashiko AI review is valid, then it would also
> exist with the previous implementation.

Note, Sashiko's reviews are statistical, which means you can get
different issues brought up by running it twice on the same code.

-- Steve

  reply	other threads:[~2026-05-27 19:49 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 14:25 [PATCH v16 00/20] unwind_deferred: Implement sframe handling Jens Remus
2026-05-21 14:25 ` [PATCH v16 01/20] unwind_user: Add generic and arch-specific headers to MAINTAINERS Jens Remus
2026-05-21 14:25 ` [PATCH v16 02/20] unwind_user/sframe: Add support for reading .sframe headers Jens Remus
2026-05-21 14:51   ` sashiko-bot
2026-05-22 10:11     ` Jens Remus
2026-05-27 20:09   ` Steven Rostedt
2026-05-21 14:25 ` [PATCH v16 03/20] unwind_user/sframe: Store .sframe section data in per-mm maple tree Jens Remus
2026-05-21 15:04   ` sashiko-bot
2026-05-27 20:20   ` Steven Rostedt
2026-05-21 14:25 ` [PATCH v16 04/20] x86/uaccess: Add unsafe_copy_from_user() implementation Jens Remus
2026-05-21 14:25 ` [PATCH v16 05/20] unwind_user/sframe: Add support for reading .sframe contents Jens Remus
2026-05-21 15:18   ` sashiko-bot
2026-05-22  9:26     ` Jens Remus
2026-05-27 19:49       ` Steven Rostedt [this message]
2026-05-21 14:25 ` [PATCH v16 06/20] unwind_user/sframe: Detect .sframe sections in executables Jens Remus
2026-05-21 14:25 ` [PATCH v16 07/20] unwind_user/sframe: Wire up unwind_user to sframe Jens Remus
2026-05-21 14:53   ` sashiko-bot
2026-05-22  9:55     ` Jens Remus
2026-05-21 14:25 ` [PATCH v16 08/20] unwind_user: Stop when reaching an outermost frame Jens Remus
2026-05-21 14:47   ` sashiko-bot
2026-05-22 10:12     ` Jens Remus
2026-05-21 14:25 ` [PATCH v16 09/20] unwind_user/sframe: Add support for outermost frame indication Jens Remus
2026-05-21 14:25 ` [PATCH v16 10/20] unwind_user/sframe: Remove .sframe section on detected corruption Jens Remus
2026-05-21 15:19   ` sashiko-bot
2026-05-22 10:03     ` Jens Remus
2026-05-21 14:25 ` [PATCH v16 11/20] unwind_user/sframe: Show file name in debug output Jens Remus
2026-05-21 15:05   ` sashiko-bot
2026-05-22  9:58     ` Jens Remus
2026-05-21 14:25 ` [PATCH v16 12/20] unwind_user/sframe: Add .sframe validation option Jens Remus
2026-05-21 15:02   ` sashiko-bot
2026-05-22 10:08     ` Jens Remus
2026-05-21 14:25 ` [PATCH v16 13/20] unwind_user: Enable archs that pass RA in a register Jens Remus
2026-05-21 14:25 ` [PATCH v16 14/20] unwind_user: Flexible FP/RA recovery rules Jens Remus
2026-05-21 14:25 ` [PATCH v16 15/20] unwind_user: Flexible CFA " Jens Remus
2026-05-21 14:25 ` [PATCH v16 16/20] unwind_user/sframe: Add support for SFrame V3 flexible FDEs Jens Remus
2026-05-21 15:14   ` sashiko-bot
2026-05-22 10:15     ` Jens Remus
2026-05-21 14:25 ` [PATCH v16 17/20] unwind_user/sframe: Separate reading of FRE from reading of FRE data words Jens Remus
2026-05-21 14:25 ` [PATCH v16 18/20] unwind_user/sframe: Duplicate registered .sframe section data on clone/fork Jens Remus
2026-05-21 15:37   ` sashiko-bot
2026-05-21 14:25 ` [PATCH v16 19/20] unwind_user/sframe/x86: Enable sframe unwinding on x86 Jens Remus
2026-05-21 14:25 ` [PATCH v16 20/20] unwind_user/sframe: Add prctl() interface for registering .sframe sections Jens Remus
2026-05-21 15:23   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260527154918.5204c6da@fedora \
    --to=rostedt@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=dylanbhatch@google.com \
    --cc=ibhagatgnu@gmail.com \
    --cc=jpoimboe@kernel.org \
    --cc=jremus@linux.ibm.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox