Re: [PATCH net-next 13/14] selftests/bpf: Test skb_ext read from sk_skb stream verdict hook

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The multi-line comment preceding `test_skb_ext_sk_skb` violates the BPF subsystem comment style guidelines by placing text on the same line as the opening `/*`.
--

--- Patch [13]: [PATCH net-next 13/14] selftests/bpf: Test skb_ext read from sk_skb stream verdict hook ---
commit a5b31d7bdebf3ee8a7f99246938befdabdfff8e4
Author: Jakub Sitnicki <jakub@cloudflare.com>

selftests/bpf: Test skb_ext read from sk_skb stream verdict hook

This commit adds a selftest to verify that skb_ext survives across the TC
ingress to sk_skb verdict hook. It implements this by writing to skb_ext
from TC on loopback and reading from it in the sockmap verdict program.

> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c b/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c
> index 5f9247941aa01..f5fbc19757e3e 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_context_test_run.c
[ ... ]
> @@ -1560,6 +1561,82 @@ static void test_skb_ext_seg6local(struct test_xdp_meta *skel)
>  		unlink(SEG6_PIN_PATH);
>  }
>  
> +/* Test skb_ext survival across TC ingress -> sk_skb verdict hook.
> + * TC ingress writes skb_ext on loopback; the verdict program reads it
> + * on skb delivery to a socket in the sockmap.
> + */

[Severity: Low]
This isn't a bug, but does this multi-line comment format follow the BPF
subsystem style guidelines? The preferred modern kernel style for BPF
subsystem files places the opening /* on its own line before the text begins.

> +static void test_skb_ext_sk_skb(struct test_xdp_meta *skel)
> +{
> +	LIBBPF_OPTS(bpf_tc_hook, tc_hook,
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260814-bpf-meta-inside-skb-ext-v1-0-767edd862656@cloudflare.com?part=13