BPF List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Xu Yunxiang <xyx2021@mail.ustc.edu.cn>
Cc: stable@vger.kernel.org, bpf@vger.kernel.org, ast@kernel.org,
	daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
	martin.lau@linux.dev, ameryhung@gmail.com,
	joannelkoong@gmail.com, sashal@kernel.org
Subject: Re: [PATCH 6.12.y v4 0/3] bpf: fix dynptr release handling
Date: Mon, 31 Aug 2026 13:54:27 +0200	[thread overview]
Message-ID: <2026083135-hammock-bagel-3147@gregkh> (raw)
In-Reply-To: <20260831001552.3223196-1-xyx2021@mail.ustc.edu.cn>

On Mon, Aug 31, 2026 at 08:15:49AM +0800, Xu Yunxiang wrote:
> Upstream commit 308c7a0ae885 ("bpf: Refactor object relationship
> tracking and fix dynptr UAF bug") fixes these lifetime bugs as part of
> an 11-file parent_id refactor. That refactor cannot be applied to
> 6.12.y, which still represents the relationships with dynptr_id and
> ref_obj_id.
> 
> This series supplies three stable-sized equivalents using the existing
> 6.12.y representation. Patch 1 invalidates slice registers with the
> released dynptr_id. Patch 2 propagates a referenced-dynptr release
> error instead of turning a callback rejection into a kernel warning.
> Patch 3 scans every active call frame when invalidating cloned dynptr
> stack slots. They are split because the bugs have different
> introducing commits and independently testable effects.
> 
> These patches are stable-specific implementations authored for the old
> verifier, not cherry-picks of Amery Hung's upstream diff. Each commit
> keeps 308c7a0ae885 as the upstream provenance for the equivalent fix
> and documents how its implementation differs.
> 
> Changes in v4:
> 
> - make Xu Yunxiang the author of all three stable-specific
>   implementations;
> - remove the authorship, sign-off, and ack trailers copied from
>   308c7a0ae885 because those developers did not write or review these
>   rewritten stable patches;

That's not ok at all!  Take the original commit, and "just" backport
that, keeping the original changelog and authorship information
everywhere.

To pass this off as your own work isn't ok.

Also, you forgot the 6.18 and 7.1 trees, we can't take fixes only for
older kernels.

Please fix up all of these and do it properly.

thanks,

greg k-h

  parent reply	other threads:[~2026-08-31 11:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  0:15 [PATCH 6.12.y v4 0/3] bpf: fix dynptr release handling Xu Yunxiang
2026-08-31  0:15 ` [PATCH 6.12.y v4 1/3] bpf: Invalidate dynptr slices by dynptr_id on release Xu Yunxiang
2026-08-31  0:15 ` [PATCH 6.12.y v4 2/3] bpf: Propagate referenced dynptr release errors Xu Yunxiang
2026-08-31  0:36   ` sashiko-bot
2026-08-31  0:15 ` [PATCH 6.12.y v4 3/3] bpf: Invalidate dynptr clones in every call frame on release Xu Yunxiang
2026-08-31 11:54 ` Greg KH [this message]
2026-08-31 15:58   ` [PATCH 6.12.y v4 0/3] bpf: fix dynptr release handling Xu Yunxiang
2026-08-31 20:15     ` Amery Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026083135-hammock-bagel-3147@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ameryhung@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=joannelkoong@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=xyx2021@mail.ustc.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox