* [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"
@ 2025-11-06 11:04 Colin Ian King
2025-11-11 20:03 ` Martin KaFai Lau
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2025-11-06 11:04 UTC (permalink / raw)
To: Andrii Nakryiko, Eduard Zingerman, Alexei Starovoitov,
Daniel Borkmann, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
Shuah Khan, bpf, linux-kselftest
Cc: kernel-janitors, linux-kernel
There is a spelling mistake in an ASSERT_OK message. Fix it.
Signed-off-by: Colin Ian King <coking@nvidia.com>
---
tools/testing/selftests/bpf/prog_tests/xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/xsk.c b/tools/testing/selftests/bpf/prog_tests/xsk.c
index dd4c35c0e428..04f9a5e73e5e 100644
--- a/tools/testing/selftests/bpf/prog_tests/xsk.c
+++ b/tools/testing/selftests/bpf/prog_tests/xsk.c
@@ -74,7 +74,7 @@ static void test_xsk(const struct test_spec *test_to_run, enum test_mode mode)
if (!ASSERT_OK_PTR(ifobj_rx, "create ifobj_rx"))
goto delete_tx;
- if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "conigure ifobj"))
+ if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "configure ifobj"))
goto delete_rx;
ret = get_hw_ring_size(ifobj_tx->ifname, &ifobj_tx->ring);
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"
2025-11-06 11:04 Colin Ian King
@ 2025-11-11 20:03 ` Martin KaFai Lau
0 siblings, 0 replies; 4+ messages in thread
From: Martin KaFai Lau @ 2025-11-11 20:03 UTC (permalink / raw)
To: Colin Ian King
Cc: Andrii Nakryiko, Eduard Zingerman, Alexei Starovoitov,
Daniel Borkmann, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa, Shuah Khan, bpf,
linux-kselftest, kernel-janitors, linux-kernel
On 11/6/25 3:04 AM, Colin Ian King wrote:
> There is a spelling mistake in an ASSERT_OK message. Fix it.
>
> Signed-off-by: Colin Ian King <coking@nvidia.com>
> ---
> tools/testing/selftests/bpf/prog_tests/xsk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/xsk.c b/tools/testing/selftests/bpf/prog_tests/xsk.c
> index dd4c35c0e428..04f9a5e73e5e 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xsk.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xsk.c
> @@ -74,7 +74,7 @@ static void test_xsk(const struct test_spec *test_to_run, enum test_mode mode)
> if (!ASSERT_OK_PTR(ifobj_rx, "create ifobj_rx"))
> goto delete_tx;
>
> - if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "conigure ifobj"))
> + if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "configure ifobj"))
Please squash with another typo fixes (https://lore.kernel.org/bpf/20251106110016.15960-1-coking@nvidia.com/)
into one single patch and use the "bpf-next" tag.
pw-bot: cr
> goto delete_rx;
>
> ret = get_hw_ring_size(ifobj_tx->ifname, &ifobj_tx->ring);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"
@ 2026-09-03 15:03 Colin Ian King
2026-09-04 8:14 ` Bastien Curutchet
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2026-09-03 15:03 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Eduard Zingerman, Kumar Kartikeya Dwivedi, Martin KaFai Lau,
Song Liu, Yonghong Song, Emil Tsalapatis, Ihor Solodrai,
Shuah Khan, Maciej Fijalkowski, Bastien Curutchet, bpf,
linux-kselftest
Cc: kernel-janitors, linux-kernel
There is a spelling mistake in an assert message. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
tools/testing/selftests/bpf/prog_tests/xsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/xsk.c b/tools/testing/selftests/bpf/prog_tests/xsk.c
index 6e2f63ee2a6c..772f3dd7ce64 100644
--- a/tools/testing/selftests/bpf/prog_tests/xsk.c
+++ b/tools/testing/selftests/bpf/prog_tests/xsk.c
@@ -75,7 +75,7 @@ static void test_xsk(const struct test_spec *test_to_run, enum test_mode mode)
if (!ASSERT_OK_PTR(ifobj_rx, "create ifobj_rx"))
goto delete_tx;
- if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "conigure ifobj"))
+ if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "configure ifobj"))
goto delete_rx;
ret = get_hw_ring_size(ifobj_tx->ifname, &ifobj_tx->ring);
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"
2026-09-03 15:03 [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure" Colin Ian King
@ 2026-09-04 8:14 ` Bastien Curutchet
0 siblings, 0 replies; 4+ messages in thread
From: Bastien Curutchet @ 2026-09-04 8:14 UTC (permalink / raw)
To: Colin Ian King, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Eduard Zingerman, Kumar Kartikeya Dwivedi,
Martin KaFai Lau, Song Liu, Yonghong Song, Emil Tsalapatis,
Ihor Solodrai, Shuah Khan, Maciej Fijalkowski, bpf,
linux-kselftest
Cc: kernel-janitors, linux-kernel
Hi,
I think your mail subject should have started with [PATCH bpf-next] (cf
https://elixir.bootlin.com/linux/v7.2.2/source/Documentation/bpf/bpf_devel_QA.rst#L157-L166)
Also other commits to this file start with selftests/xsk, but that's a
nit pick.
On 9/3/26 5:03 PM, Colin Ian King wrote:
> There is a spelling mistake in an assert message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
Regards,
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-04 8:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-03 15:03 [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure" Colin Ian King
2026-09-04 8:14 ` Bastien Curutchet
-- strict thread matches above, loose matches on Subject: below --
2025-11-06 11:04 Colin Ian King
2025-11-11 20:03 ` Martin KaFai Lau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox