Re: [PATCH net-next v6 01/12] gve: add struct gve_device_info to hold device properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Leftover fields `default_min_ring_size` and `default_num_queues` in `struct gve_priv` are completely unused and should have been removed.
--

commit 1e8912b037c461a4e97b883a09cc8e52ac72a6ed
Author: Harshitha Ramamurthy <hramamurthy@google.com>

gve: add struct gve_device_info to hold device properties

This commit introduces struct gve_device_info to encapsulate device
properties in preparation for MailboxQ support. It updates the driver logic
to populate and read from this new structure instead of setting the fields
directly in struct gve_priv.

> diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h
> index c280ff35ee771..021adb9108dff 100644
> --- a/drivers/net/ethernet/google/gve/gve.h
> +++ b/drivers/net/ethernet/google/gve/gve.h
> @@ -797,6 +797,34 @@ struct gve_ptp {
>  	struct gve_priv *priv;
>  };
>  
> +struct gve_device_info {
> +	enum gve_queue_format queue_format;
> +	u16 default_tx_queues;
> +	u16 default_rx_queues;
[ ... ]
> +	bool default_min_ring_size;
> +	bool nic_timestamp_supported;
> +	bool modify_ring_size_enabled;
> +	bool cache_rss_config;
> +};
> +
>  struct gve_priv {
>  	struct net_device *dev;

[Severity: Low]
With the introduction of struct gve_device_info and the migration of the logic
to use device_info.default_min_ring_size and device_info.default_tx_queues /
device_info.default_rx_queues, should the old fields default_min_ring_size
and default_num_queues be removed from struct gve_priv?

Looking at struct gve_priv in gve.h, these fields appear to be left over:

struct gve_priv {
    ...
    bool default_min_ring_size;
    ...
    u16 default_num_queues; /* default num queues to set up */
    ...
};

They seem to be completely unused now and are left occupying memory as dead
code.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909191136.3811892-1-hramamurthy@google.com?part=1