Re: [PATCH bpf-next v3 13/15] selftests/bpf: Add inline-asm tests for by-value arguments

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment does not follow the required kernel BPF comment style.
--

commit d1826c8bebe9c02679f7bde2ef6a1536675d8bf2
Author: Yonghong Song <yonghong.song@linux.dev>
selftests/bpf: Add inline-asm tests for by-value arguments

This commit adds inline-asm tests to cover struct argument passing,
specifically for structs passed in register pairs, refused pointers, and
structs too large for by-value passing. It also checks various placements
that global functions cannot have.

> diff --git a/tools/testing/selftests/bpf/progs/aggregate_arg_func.c b/tools/testing/selftests/bpf/progs/aggregate_arg_func.c
> new file mode 100644
> index 0000000000000..ae3faa8a4a940
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/aggregate_arg_func.c

[ ... ]

> +#if defined(__BPF_FEATURE_STACK_ARGUMENT)
> +
> +/* One slot per parameter, so the slot count is settled before the parameters
> + * are walked. The cases below reach the same count only once they have been.
> + */
> +__noinline __u64 global_arg_six_scalars(int a, int b, int c, int d, int e, int f)

[Severity: Low]
This isn't a bug, but does this multi-line comment follow the preferred BPF
subsystem comment style? The guidelines require multi-line comments to have
the opening /* on its own line, with the text starting on the next line.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911154914.2004336-1-yonghong.song@linux.dev?part=13