Re: [PATCH net-next 04/13] selftests: net: add a generic rule for BPF skeletons

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Makefile shell redirection leaves empty file on failure
--

commit 819b3d37545dcc960fb225a24a62ad26c2989d48
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

selftests: net: add a generic rule for BPF skeletons

This commit adds a pattern rule in the networking selftests Makefile to
generate skeleton headers from BPF object files using bpftool.

> diff --git a/tools/testing/selftests/net/bpf.mk b/tools/testing/selftests/net/bpf.mk
> --- a/tools/testing/selftests/net/bpf.mk
> +++ b/tools/testing/selftests/net/bpf.mk
> @@ -42,6 +43,10 @@ $(BPF_PROG_OBJS): $(OUTPUT)/%.o : %.c $(BPFOBJ) | $(MAKE_DIRS)
[ ... ]
> +$(OUTPUT)/%.skel.h: $(OUTPUT)/%.bpf.o
> +	$(call msg,GEN-SKEL,,$@)
> +	$(Q)$(BPFTOOL) gen skeleton $< name $(notdir $*) > $@

[Severity: Low]
Does this shell redirection leave an empty or corrupted file on failure?

Because the shell truncates or creates the target file before the command
executes, a failure in the bpftool command might leave a corrupted file
in place.

Since .DELETE_ON_ERROR: is not defined in net/Makefile or net/bpf.mk,
GNU Make will consider the file up-to-date on subsequent runs. This
could cause the next make invocation to fail and require a manual cleanup.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001202124.692591-1-maciej.fijalkowski@intel.com?part=4