From: Chen Pei <cp0613@linux.alibaba.com>
To: sashiko-bot@kernel.org
Cc: bpf@vger.kernel.org, sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH bpf-next 2/3] selftests/bpf: Enable private stack tests for riscv64
Date: Thu, 15 Oct 2026 16:00:11 +0800 [thread overview]
Message-ID: <20261015080014.6366-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <sashiko-outbox-172140@kernel.org>
This one I am not taking: what gates the test is large stack support, a
JIT capability separate from the private stack this series adds.
> [Severity: Medium]
> Was the private_stack_two_frames test in verifier_large_stack.c missed
> in this patch?
> Since the RV64 JIT now supports the private stack, should __arch_riscv64
> be added to this test as well so that the riscv64 architecture receives
> this large stack test coverage?
The test builds a 2048 byte frame. Above MAX_BPF_STACK that is only
accepted when bpf_prog_stack_limit() returns MAX_BPF_STACK_JIT, which
requires bpf_jit_supports_large_stack() in the JIT as well as
bpf_jit_supports_subprog_tailcalls(); the former exists only for x86-64
and arm64. riscv64 rejects the program on the depth with or without a
private stack, which is why it skips behind
is_large_stack_supported(). Adding __arch_riscv64 would turn that skip
into a failure.
The other comments on this set are valid and are taken in v2.
Best regards,
Chen
next prev parent reply other threads:[~2026-10-15 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 2:12 [PATCH bpf-next 0/3] riscv: bpf: Add BPF private stack support Chen Pei
2026-10-15 2:12 ` [PATCH bpf-next 1/3] " Chen Pei
2026-10-15 2:58 ` bot+bpf-ci
2026-10-15 2:12 ` [PATCH bpf-next 2/3] selftests/bpf: Enable private stack tests for riscv64 Chen Pei
2026-10-15 2:22 ` sashiko-bot
2026-10-15 8:00 ` Chen Pei [this message]
2026-10-15 2:12 ` [PATCH bpf-next 3/3] selftests/bpf: Add a runtime test for private stack and stack arguments Chen Pei
2026-10-15 2:23 ` sashiko-bot
2026-10-15 2:59 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015080014.6366-1-cp0613@linux.alibaba.com \
--to=cp0613@linux.alibaba.com \
--cc=bpf@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox