From: sashiko-bot@kernel.org
To: "Chen Pei" <cp0613@linux.alibaba.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 2/3] selftests/bpf: Enable private stack tests for riscv64
Date: Thu, 15 Oct 2026 02:22:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-172140@kernel.org> (raw)
In-Reply-To: <20261015021238.5657-3-cp0613@linux.alibaba.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] bpf: Missing enablement for private stack test in verifier_large_stack.c for riscv64
--
commit 6110b152bad2869b21761f9abd7de948a19afdbf
Author: Chen Pei <cp0613@linux.alibaba.com>
selftests/bpf: Enable private stack tests for riscv64
This commit enables the verifier and struct_ops private-stack tests to
run on riscv64 by adding the expected RV64 JITed instruction patterns.
> selftests/bpf: Enable private stack tests for riscv64
>
> The RV64 JIT now supports the private stack. Allow the existing
> verifier and struct_ops private-stack tests to run on riscv64 and add
> the expected RV64 JITed instruction patterns.
[Severity: Medium]
Was the private_stack_two_frames test in verifier_large_stack.c missed
in this patch?
The commit enables private-stack tests in verifier_private_stack.c and
struct_ops_private_stack.c, but verifier_large_stack.c contains a test
that explicitly validates the verifier log messages for a 2048-byte large
stack (private stack) setup, which is currently restricted to x86_64 and
arm64:
tools/testing/selftests/bpf/progs/verifier_large_stack.c:
__arch_x86_64
__arch_arm64
__success __log_level(4)
__msg("stack depth max 2048")
__msg("subprog 0 (private_stack_two_frames) main {{.*}} stack 2048")
__msg("subprog 1 (priv_stack_frame_2048) static {{.*}} stack 2048")
__naked void private_stack_two_frames(void)
Since the RV64 JIT now supports the private stack, should __arch_riscv64
be added to this test as well so that the riscv64 architecture receives
this large stack test coverage?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015021238.5657-1-cp0613@linux.alibaba.com?part=2
next prev parent reply other threads:[~2026-10-15 2:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 2:12 [PATCH bpf-next 0/3] riscv: bpf: Add BPF private stack support Chen Pei
2026-10-15 2:12 ` [PATCH bpf-next 1/3] " Chen Pei
2026-10-15 2:58 ` bot+bpf-ci
2026-10-15 2:12 ` [PATCH bpf-next 2/3] selftests/bpf: Enable private stack tests for riscv64 Chen Pei
2026-10-15 2:22 ` sashiko-bot [this message]
2026-10-15 8:00 ` Chen Pei
2026-10-15 2:12 ` [PATCH bpf-next 3/3] selftests/bpf: Add a runtime test for private stack and stack arguments Chen Pei
2026-10-15 2:23 ` sashiko-bot
2026-10-15 2:59 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172140@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cp0613@linux.alibaba.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox