* [PATCH bpf v1] selftests/bpf: Fix CO-RE relocation of anonymous unions for bpf-gcc
@ 2026-11-17 9:45 Jiayuan Chen
2026-11-17 11:19 ` Michal Luczaj
0 siblings, 1 reply; 2+ messages in thread
From: Jiayuan Chen @ 2026-11-17 9:45 UTC (permalink / raw)
To: bpf, ast
Cc: Jiayuan Chen, Daniel Borkmann, Andrii Nakryiko, Eduard Zingerman,
Kumar Kartikeya Dwivedi, Martin KaFai Lau, Song Liu,
Yonghong Song, Jiri Olsa, Emil Tsalapatis, Ihor Solodrai,
Shuah Khan, John Fastabend, Michal Luczaj, Sechang Lim,
linux-kselftest, linux-kernel
bpf-gcc fails to load test_trace_iter_unix:
Error: #766/6 verifier_sockmap_mutate/test_trace_iter_unix
libbpf: elf: skipping section(3) .data (size 0)
libbpf: elf: skipping unrecognized data section(18) .comment
run_subtest:PASS:obj_open_mem 0 nsec
libbpf: prog 'test_trace_iter_unix': relo #0: insn #0 (LDX/ST/STX) accesses field incorrectly. ...
libbpf: prog 'test_trace_iter_unix': BPF program load failed: -EINVAL
libbpf: prog 'test_trace_iter_unix': failed to load: -EINVAL
libbpf: failed to load object 'verifier_sockmap_mutate'
run_subtest:PASS:unexpected_load_success 0 nsec
validate_msgs:FAIL:1014 expect_msg
VERIFIER LOG:
=============
0: R1=ctx() R10=fp0
; @ verifier_sockmap_mutate.c:124
0: <invalid CO-RE relocation>
failed to resolve CO-RE relocation <byte_off> [4] struct bpf_iter__unix (0:0 @ offset 0)
processed 1 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
=============
EXPECTED SUBSTR: 'cannot update sockmap in this context'
GCC only applies preserve_access_index to types that carry the attribute
themselves. The anonymous union holding the sock pointer doesn't, so the
CO-RE access stops at the union ("0:0") instead of reaching the pointer
("0:0:0"), and libbpf rejects the relocation. Mark the unions too.
Fixes: e16c83fa764f ("selftests/bpf: Add negative test for sockmap update from non-sockmap iter")
Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
---
tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c b/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c
index 1516fe1524bb..68b1a5323470 100644
--- a/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c
+++ b/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c
@@ -16,13 +16,13 @@ struct sock {
struct bpf_iter__sockmap {
union {
struct sock *sk;
- };
+ } __attribute__((preserve_access_index));
} __attribute__((preserve_access_index));
struct bpf_iter__unix {
union {
struct sock *unix_sk;
- };
+ } __attribute__((preserve_access_index));
} __attribute__((preserve_access_index));
struct {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf v1] selftests/bpf: Fix CO-RE relocation of anonymous unions for bpf-gcc
2026-11-17 9:45 [PATCH bpf v1] selftests/bpf: Fix CO-RE relocation of anonymous unions for bpf-gcc Jiayuan Chen
@ 2026-11-17 11:19 ` Michal Luczaj
0 siblings, 0 replies; 2+ messages in thread
From: Michal Luczaj @ 2026-11-17 11:19 UTC (permalink / raw)
To: Jiayuan Chen, bpf, ast
Cc: Daniel Borkmann, Andrii Nakryiko, Eduard Zingerman,
Kumar Kartikeya Dwivedi, Martin KaFai Lau, Song Liu,
Yonghong Song, Jiri Olsa, Emil Tsalapatis, Ihor Solodrai,
Shuah Khan, John Fastabend, Sechang Lim, linux-kselftest,
linux-kernel
On 11/17/26 10:45, Jiayuan Chen wrote:
> bpf-gcc fails to load test_trace_iter_unix:
>
> Error: #766/6 verifier_sockmap_mutate/test_trace_iter_unix
> libbpf: elf: skipping section(3) .data (size 0)
> libbpf: elf: skipping unrecognized data section(18) .comment
> run_subtest:PASS:obj_open_mem 0 nsec
> libbpf: prog 'test_trace_iter_unix': relo #0: insn #0 (LDX/ST/STX) accesses field incorrectly. ...
> libbpf: prog 'test_trace_iter_unix': BPF program load failed: -EINVAL
> libbpf: prog 'test_trace_iter_unix': failed to load: -EINVAL
> libbpf: failed to load object 'verifier_sockmap_mutate'
> run_subtest:PASS:unexpected_load_success 0 nsec
> validate_msgs:FAIL:1014 expect_msg
> VERIFIER LOG:
> =============
> 0: R1=ctx() R10=fp0
> ; @ verifier_sockmap_mutate.c:124
> 0: <invalid CO-RE relocation>
> failed to resolve CO-RE relocation <byte_off> [4] struct bpf_iter__unix (0:0 @ offset 0)
> processed 1 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
> =============
> EXPECTED SUBSTR: 'cannot update sockmap in this context'
>
> GCC only applies preserve_access_index to types that carry the attribute
> themselves. The anonymous union holding the sock pointer doesn't, so the
> CO-RE access stops at the union ("0:0") instead of reaching the pointer
> ("0:0:0"), and libbpf rejects the relocation. Mark the unions too.
>
> Fixes: e16c83fa764f ("selftests/bpf: Add negative test for sockmap update from non-sockmap iter")
> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
> ---
> tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c b/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c
> index 1516fe1524bb..68b1a5323470 100644
> --- a/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c
> +++ b/tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c
> @@ -16,13 +16,13 @@ struct sock {
> struct bpf_iter__sockmap {
> union {
> struct sock *sk;
> - };
> + } __attribute__((preserve_access_index));
> } __attribute__((preserve_access_index));
>
> struct bpf_iter__unix {
> union {
> struct sock *unix_sk;
> - };
> + } __attribute__((preserve_access_index));
> } __attribute__((preserve_access_index));
>
> struct {
What about dropping the unions?
-struct sock {
-} __attribute__((preserve_access_index));
-
struct bpf_iter__sockmap {
- union {
- struct sock *sk;
- };
+ struct sock *sk;
} __attribute__((preserve_access_index));
struct bpf_iter__unix {
- union {
- struct sock *unix_sk;
- };
+ struct sock *unix_sk;
} __attribute__((preserve_access_index));
Works under clang.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 9:45 [PATCH bpf v1] selftests/bpf: Fix CO-RE relocation of anonymous unions for bpf-gcc Jiayuan Chen
2026-11-17 11:19 ` Michal Luczaj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox