From: Yonghong Song <yonghong.song@linux.dev>
To: Dave Thaler <dthaler1968@googlemail.com>, bpf@vger.kernel.org
Cc: bpf@ietf.org, Dave Thaler <dthaler1968@gmail.com>
Subject: Re: [PATCH bpf-next] bpf, docs: Clarify call local offset
Date: Sat, 25 May 2024 09:47:41 -0700 [thread overview]
Message-ID: <317b6459-43e9-44b5-a7ee-3af094a131a0@linux.dev> (raw)
In-Reply-To: <20240525153332.21355-1-dthaler1968@gmail.com>
On 5/25/24 9:33 AM, Dave Thaler wrote:
> In the Jump instructions section it explains that the offset is
> "relative to the instruction following the jump instruction".
> But the program-local section confusingly said "referenced by
> offset from the call instruction, similar to JA".
>
> This patch updates that sentence with consistent wording, saying
> it's relative to the instruction following the call instruction.
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
WARNING: multiple messages have this Message-ID (diff)
From: Yonghong Song <yonghong.song@linux.dev>
To: Dave Thaler <dthaler1968@googlemail.com>, bpf@vger.kernel.org
Cc: bpf@ietf.org, Dave Thaler <dthaler1968@gmail.com>
Subject: [Bpf] Re: [PATCH bpf-next] bpf, docs: Clarify call local offset
Date: Sat, 25 May 2024 09:47:41 -0700 [thread overview]
Message-ID: <317b6459-43e9-44b5-a7ee-3af094a131a0@linux.dev> (raw)
Message-ID: <20240525164741.aPuSQ5OvNahWEoP6sAbcFf1-RPRADYg17k-CAPLh_ks@z> (raw)
In-Reply-To: <20240525153332.21355-1-dthaler1968@gmail.com>
On 5/25/24 9:33 AM, Dave Thaler wrote:
> In the Jump instructions section it explains that the offset is
> "relative to the instruction following the jump instruction".
> But the program-local section confusingly said "referenced by
> offset from the call instruction, similar to JA".
>
> This patch updates that sentence with consistent wording, saying
> it's relative to the instruction following the call instruction.
>
> Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
--
Bpf mailing list -- bpf@ietf.org
To unsubscribe send an email to bpf-leave@ietf.org
next prev parent reply other threads:[~2024-05-25 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 15:33 [PATCH bpf-next] bpf, docs: Clarify call local offset Dave Thaler
2024-05-25 15:33 ` [Bpf] " Dave Thaler
2024-05-25 16:47 ` Yonghong Song [this message]
2024-05-25 16:47 ` [Bpf] " Yonghong Song
2024-05-25 17:44 ` Alexei Starovoitov
2024-05-25 17:44 ` [Bpf] " Alexei Starovoitov
2024-05-25 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=317b6459-43e9-44b5-a7ee-3af094a131a0@linux.dev \
--to=yonghong.song@linux.dev \
--cc=bpf@ietf.org \
--cc=bpf@vger.kernel.org \
--cc=dthaler1968@gmail.com \
--cc=dthaler1968@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox