From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
acme@kernel.org, jolsa@kernel.org, ast@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org,
yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
sdf@google.com, haoluo@google.com, mykolal@fb.com,
bpf@vger.kernel.org
Subject: Re: [PATCH v2 dwarves 0/5] pahole, btf_encoder: support --btf_features
Date: Tue, 17 Oct 2023 21:55:56 +0300 [thread overview]
Message-ID: <33927efd0799ee11f576ed6fef2266338185dcfe.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzZJv5OyQ5Hktgj2GKD+usgiDx9R+TjyTScE1wPBWjn4Qg@mail.gmail.com>
On Tue, 2023-10-17 at 11:53 -0700, Andrii Nakryiko wrote:
> > > if [ "${pahole_ver}" -ge "126" ]; then
> > > extra_pahole_opt="-j --lang_exclude=rust
> > > --btf_features=encode_force,var,float,decl_tag,type_tag,enum64,optimized,consistent"
> > > fi
> >
> > Nitpick, could you please update the line above as below?
> >
> > --btf_features_strict=encode_force,var,float,decl_tag,type_tag,enum64,optimized_func,consistent_func
>
> We do not want "strict" behavior for the kernel build script.
Oh, sorry, my comment was about '_func' suffixes,
it should have been --btf_features, of course.
prev parent reply other threads:[~2023-10-17 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 15:33 [PATCH v2 dwarves 0/5] pahole, btf_encoder: support --btf_features Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 1/5] btf_encoder, pahole: move btf encoding options into conf_load Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 2/5] dwarves: move ARRAY_SIZE() to dwarves.h Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 3/5] pahole: add --btf_features support Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 4/5] pahole: add --supported_btf_features Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 5/5] pahole: add --btf_features_strict to reject unknown BTF features Alan Maguire
2023-10-17 12:53 ` Eduard Zingerman
2023-10-17 15:59 ` Alan Maguire
2023-10-17 16:05 ` Eduard Zingerman
2023-10-16 13:56 ` [PATCH v2 dwarves 0/5] pahole, btf_encoder: support --btf_features Jiri Olsa
2023-10-17 12:57 ` Eduard Zingerman
2023-10-17 18:53 ` Andrii Nakryiko
2023-10-17 18:55 ` Eduard Zingerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33927efd0799ee11f576ed6fef2266338185dcfe.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox