From: Eduard Zingerman <eddyz87@gmail.com>
To: Alan Maguire <alan.maguire@oracle.com>,
acme@kernel.org, andrii.nakryiko@gmail.com
Cc: jolsa@kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, mykolal@fb.com, bpf@vger.kernel.org,
Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH v2 dwarves 5/5] pahole: add --btf_features_strict to reject unknown BTF features
Date: Tue, 17 Oct 2023 19:05:54 +0300 [thread overview]
Message-ID: <d7dc70644cb914f53e933298fa87a29cb762fdc4.camel@gmail.com> (raw)
In-Reply-To: <f59f5d60-c33e-1786-f442-82ea795059b2@oracle.com>
On Tue, 2023-10-17 at 16:59 +0100, Alan Maguire wrote:
[...]
> > Sorry for late response.
> >
> > This won't work if --btf_features_strict specifies an incomplete list, e.g.:
> >
> > $ pahole --btf_features_strict=decl_tag,enum64 --btf_encode_detached=/dev/null ~/work/tmp/test.o
> > Feature in 'decl_tag,enum64' is not supported. 'pahole --supported_btf_features' shows the list of features supported.
> >
> > Also, I think it would be good to print exactly which feature is not supported.
> > What do you think about modification as in the end of this email?
> > (applied on top of your series).
> >
>
> Argh, apologies, I could have sworn I'd tested this.
No worries.
> Thanks, the fix looks great, and I tested your modifications and all
> looks good. I can add a Co-developed-by: tag for v3, or let me know
> what attribution works best for you. I'll fix the cover letter as
> per your other email also. Thanks for the help!
>
> Alan
I don't think "Co-developed-by" is necessary, I can just add ack in the end.
If you think that some attribution info is necessary for bookkeeping reasons
maybe "Suggested-by"?
Thanks,
Eduard
[...]
next prev parent reply other threads:[~2023-10-17 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 15:33 [PATCH v2 dwarves 0/5] pahole, btf_encoder: support --btf_features Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 1/5] btf_encoder, pahole: move btf encoding options into conf_load Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 2/5] dwarves: move ARRAY_SIZE() to dwarves.h Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 3/5] pahole: add --btf_features support Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 4/5] pahole: add --supported_btf_features Alan Maguire
2023-10-13 15:33 ` [PATCH v2 dwarves 5/5] pahole: add --btf_features_strict to reject unknown BTF features Alan Maguire
2023-10-17 12:53 ` Eduard Zingerman
2023-10-17 15:59 ` Alan Maguire
2023-10-17 16:05 ` Eduard Zingerman [this message]
2023-10-16 13:56 ` [PATCH v2 dwarves 0/5] pahole, btf_encoder: support --btf_features Jiri Olsa
2023-10-17 12:57 ` Eduard Zingerman
2023-10-17 18:53 ` Andrii Nakryiko
2023-10-17 18:55 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7dc70644cb914f53e933298fa87a29cb762fdc4.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox