From: Kui-Feng Lee <sinquersw@gmail.com>
To: Martin KaFai Lau <martin.lau@linux.dev>,
Kui-Feng Lee <thinker.li@gmail.com>
Cc: kuifeng@meta.com, bpf@vger.kernel.org, ast@kernel.org,
song@kernel.org, kernel-team@meta.com, andrii@kernel.org
Subject: Re: [PATCH bpf-next v3 3/7] bpf: support epoll from bpf struct_ops links.
Date: Tue, 21 May 2024 00:31:17 -0700 [thread overview]
Message-ID: <41b07b48-f5db-49b3-b156-b3e192913712@gmail.com> (raw)
In-Reply-To: <708a8b9f-45ce-48f1-9c6b-bbf226faf679@linux.dev>
On 5/20/24 18:26, Martin KaFai Lau wrote:
> On 5/9/24 5:29 PM, Kui-Feng Lee wrote:
>> +static __poll_t bpf_struct_ops_map_link_poll(struct file *file,
>> + struct poll_table_struct *pts)
>> +{
>> + struct bpf_struct_ops_link *st_link = file->private_data;
>> +
>> + poll_wait(file, &st_link->wait_hup, pts);
>> +
>> + return (st_link->map) ? 0 : EPOLLHUP;
>
> nit. It should need a rcu_access_pointer(st_link->map).
>
sure
next prev parent reply other threads:[~2024-05-21 7:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 0:29 [PATCH bpf-next v3 0/7] Notify user space when a struct_ops object is detached/unregistered Kui-Feng Lee
2024-05-10 0:29 ` [PATCH bpf-next v3 1/7] bpf: pass bpf_struct_ops_link to callbacks in bpf_struct_ops Kui-Feng Lee
2024-05-10 0:29 ` [PATCH bpf-next v3 2/7] bpf: enable detaching links of struct_ops objects Kui-Feng Lee
2024-05-21 1:22 ` Martin KaFai Lau
2024-05-21 7:30 ` Kui-Feng Lee
2024-05-21 18:09 ` Martin KaFai Lau
2024-05-10 0:29 ` [PATCH bpf-next v3 3/7] bpf: support epoll from bpf struct_ops links Kui-Feng Lee
2024-05-21 1:26 ` Martin KaFai Lau
2024-05-21 7:31 ` Kui-Feng Lee [this message]
2024-05-10 0:29 ` [PATCH bpf-next v3 4/7] bpf: export bpf_link_inc_not_zero Kui-Feng Lee
2024-05-10 0:29 ` [PATCH bpf-next v3 5/7] selftests/bpf: test struct_ops with epoll Kui-Feng Lee
2024-05-10 0:29 ` [PATCH bpf-next v3 6/7] selftests/bpf: detach a struct_ops link from the subsystem managing it Kui-Feng Lee
2024-05-21 22:56 ` Amery Hung
2024-05-22 0:31 ` Kui-Feng Lee
2024-05-22 17:33 ` Amery Hung
2024-05-10 0:29 ` [PATCH bpf-next v3 7/7] selftests/bpf: make sure bpf_testmod handling racing link destroying well Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b07b48-f5db-49b3-b156-b3e192913712@gmail.com \
--to=sinquersw@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox