BPF List
 help / color / mirror / Atom feed
* [PATCH] docs/bpf: Fix a typo in verifier.rst
@ 2024-08-19 21:22 linsyking
  2024-08-21 21:33 ` Yonghong Song
  2024-08-29  2:33 ` Alexei Starovoitov
  0 siblings, 2 replies; 5+ messages in thread
From: linsyking @ 2024-08-19 21:22 UTC (permalink / raw)
  To: bpf; +Cc: ast, daniel, andrii, martin.lau, linsyking

In verifier.rst, there is a typo in section 'Register parentage chains'.
Caller saved registers are r0-r5, callee saved registers are r6-r9.

Here by context it means callee saved registers rather than caller saved
registers. This may confuse users.

Signed-off-by: linsyking <kxiang@umich.edu>
---
 Documentation/bpf/verifier.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/bpf/verifier.rst b/Documentation/bpf/verifier.rst
index 356894399..d23761540 100644
--- a/Documentation/bpf/verifier.rst
+++ b/Documentation/bpf/verifier.rst
@@ -418,7 +418,7 @@ The rules for correspondence between registers / stack slots are as follows:
   linked to the registers and stack slots of the parent state with the same
   indices.
 
-* For the outer stack frames, only caller saved registers (r6-r9) and stack
+* For the outer stack frames, only callee saved registers (r6-r9) and stack
   slots are linked to the registers and stack slots of the parent state with the
   same indices.
 
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs/bpf: Fix a typo in verifier.rst
  2024-08-19 21:22 [PATCH] docs/bpf: Fix a typo in verifier.rst linsyking
@ 2024-08-21 21:33 ` Yonghong Song
  2024-08-29  2:33 ` Alexei Starovoitov
  1 sibling, 0 replies; 5+ messages in thread
From: Yonghong Song @ 2024-08-21 21:33 UTC (permalink / raw)
  To: linsyking, bpf; +Cc: ast, daniel, andrii, martin.lau, linsyking


On 8/19/24 2:22 PM, linsyking wrote:
> In verifier.rst, there is a typo in section 'Register parentage chains'.
> Caller saved registers are r0-r5, callee saved registers are r6-r9.
>
> Here by context it means callee saved registers rather than caller saved
> registers. This may confuse users.
>
> Signed-off-by: linsyking <kxiang@umich.edu>

Acked-by: Yonghong Song <yonghong.song@linux.dev>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs/bpf: Fix a typo in verifier.rst
  2024-08-19 21:22 [PATCH] docs/bpf: Fix a typo in verifier.rst linsyking
  2024-08-21 21:33 ` Yonghong Song
@ 2024-08-29  2:33 ` Alexei Starovoitov
  2024-08-29  3:17   ` linsyking
  1 sibling, 1 reply; 5+ messages in thread
From: Alexei Starovoitov @ 2024-08-29  2:33 UTC (permalink / raw)
  To: linsyking
  Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, linsyking

On Mon, Aug 19, 2024 at 2:24 PM linsyking <xiangyiming2002@gmail.com> wrote:
>
> In verifier.rst, there is a typo in section 'Register parentage chains'.
> Caller saved registers are r0-r5, callee saved registers are r6-r9.
>
> Here by context it means callee saved registers rather than caller saved
> registers. This may confuse users.
>
> Signed-off-by: linsyking <kxiang@umich.edu>

Thanks for the patch, but I suspect "linsyking" is not your full name.
The kernel patch rules are strict. Please use your full first/last name
as an author and in signed-off-by.

Thanks

pw-bot: cr

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] docs/bpf: Fix a typo in verifier.rst
  2024-08-29  2:33 ` Alexei Starovoitov
@ 2024-08-29  3:17   ` linsyking
  2024-08-29 19:20     ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 5+ messages in thread
From: linsyking @ 2024-08-29  3:17 UTC (permalink / raw)
  To: bpf; +Cc: ast, daniel, andrii, martin.lau, Yiming Xiang

From: Yiming Xiang <kxiang@umich.edu>

In verifier.rst, there is a typo in section 'Register parentage chains'.
Caller saved registers are r0-r5, callee saved registers are r6-r9.

Here by context it means callee saved registers rather than caller saved
registers. This may confuse users.

Signed-off-by: Yiming Xiang <kxiang@umich.edu>
---
 Documentation/bpf/verifier.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/bpf/verifier.rst b/Documentation/bpf/verifier.rst
index 356894399..d23761540 100644
--- a/Documentation/bpf/verifier.rst
+++ b/Documentation/bpf/verifier.rst
@@ -418,7 +418,7 @@ The rules for correspondence between registers / stack slots are as follows:
   linked to the registers and stack slots of the parent state with the same
   indices.
 
-* For the outer stack frames, only caller saved registers (r6-r9) and stack
+* For the outer stack frames, only callee saved registers (r6-r9) and stack
   slots are linked to the registers and stack slots of the parent state with the
   same indices.
 
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs/bpf: Fix a typo in verifier.rst
  2024-08-29  3:17   ` linsyking
@ 2024-08-29 19:20     ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-29 19:20 UTC (permalink / raw)
  To: linsyking; +Cc: bpf, ast, daniel, andrii, martin.lau, kxiang

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 28 Aug 2024 23:17:12 -0400 you wrote:
> From: Yiming Xiang <kxiang@umich.edu>
> 
> In verifier.rst, there is a typo in section 'Register parentage chains'.
> Caller saved registers are r0-r5, callee saved registers are r6-r9.
> 
> Here by context it means callee saved registers rather than caller saved
> registers. This may confuse users.
> 
> [...]

Here is the summary with links:
  - docs/bpf: Fix a typo in verifier.rst
    https://git.kernel.org/bpf/bpf-next/c/89dd9bb25597

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-08-29 19:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-19 21:22 [PATCH] docs/bpf: Fix a typo in verifier.rst linsyking
2024-08-21 21:33 ` Yonghong Song
2024-08-29  2:33 ` Alexei Starovoitov
2024-08-29  3:17   ` linsyking
2024-08-29 19:20     ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox