From: Eduard Zingerman <eddyz87@gmail.com>
To: Yonghong Song <yonghong.song@linux.dev>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/2] bpf: Record each half of a paired return value in verifier diagnostics
Date: Mon, 24 Aug 2026 12:29:54 -0700 [thread overview]
Message-ID: <46c1cd1bc396ffce77024b1bb7e2bb8c81c20905.camel@gmail.com> (raw)
In-Reply-To: <20260824144943.991316-1-yonghong.song@linux.dev>
On Mon, 2026-08-24 at 07:49 -0700, Yonghong Song wrote:
> A subprogram returning more than 8 bytes comes back in the R0:R2 register
> pair, and prepare_func_exit() copies both registers into the caller. The
> diagnostic modification scope around that copy names only R0, so the write
> into R2 is never recorded.
>
> Fix it by opening a diagnostic modification scope for each return register.
> This way, both return registers are recorded.
>
> Fixes: 0630ad00d96d ("bpf: Add verifier support for 16-byte returns in R0: R2")
> Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
...
prev parent reply other threads:[~2026-08-24 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 14:49 [PATCH bpf-next 1/2] bpf: Record each half of a paired return value in verifier diagnostics Yonghong Song
2026-08-24 14:49 ` [PATCH bpf-next 2/2] bpf: Report which member makes a kfunc return type unsupported Yonghong Song
2026-08-24 15:35 ` bot+bpf-ci
2026-08-24 19:27 ` Eduard Zingerman
2026-08-24 20:44 ` Yonghong Song
2026-08-24 19:29 ` Eduard Zingerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46c1cd1bc396ffce77024b1bb7e2bb8c81c20905.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox