From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrei Matei <andreimatei1@gmail.com>, bpf <bpf@vger.kernel.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Hao Sun <sunhao.th@gmail.com>, kernel-team@dataexmachina.dev
Subject: Re: [PATCH bpf v3 2/3] bpf: fix accesses to uninit stack slots
Date: Sun, 03 Dec 2023 15:22:11 +0200 [thread overview]
Message-ID: <62f507b80afc6c3526a9c486af7b64c5d048bd79.camel@gmail.com> (raw)
In-Reply-To: <CABWLsesV9FvmF+j3n8ZntcNCL1gbhKOg65a5NA8s5-ro=3cYYA@mail.gmail.com>
On Sat, 2023-12-02 at 18:09 -0500, Andrei Matei wrote:
> [...]
>
> > --- a/tools/testing/selftests/bpf/progs/verifier_raw_stack.c
> > +++ b/tools/testing/selftests/bpf/progs/verifier_raw_stack.c
> > @@ -5,9 +5,10 @@
> > #include <bpf/bpf_helpers.h>
> > #include "bpf_misc.h"
> >
> > -SEC("tc")
> > +SEC("socket")
> > __description("raw_stack: no skb_load_bytes")
> > -__failure __msg("invalid read from stack R6 off=-8 size=8")
> > +__success
> > +__failure_unpriv __msg_unpriv("invalid read from stack R6 off=-8 size=8")
> > __naked void stack_no_skb_load_bytes(void)
> > {
>
> Please confirm that changing this program type is OK. I wasn't sure here.
>
> [...]
lgtm, does not seem matter in this case.
next prev parent reply other threads:[~2023-12-03 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 23:05 [PATCH bpf v3 0/3] bpf: fix accesses to uninit stack slots Andrei Matei
2023-12-02 23:05 ` [PATCH bpf v3 1/3] bpf: add some comments to stack representation Andrei Matei
2023-12-04 18:18 ` Andrii Nakryiko
2023-12-04 18:25 ` Eduard Zingerman
2023-12-02 23:05 ` [PATCH bpf v3 2/3] bpf: fix accesses to uninit stack slots Andrei Matei
2023-12-02 23:09 ` Andrei Matei
2023-12-03 13:22 ` Eduard Zingerman [this message]
2023-12-04 18:19 ` Andrii Nakryiko
2023-12-02 23:05 ` [PATCH bpf v3 3/3] bpf: minor cleanup around stack bounds Andrei Matei
2023-12-04 18:19 ` Andrii Nakryiko
2023-12-04 18:43 ` Eduard Zingerman
2023-12-04 19:06 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62f507b80afc6c3526a9c486af7b64c5d048bd79.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andreimatei1@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@dataexmachina.dev \
--cc=sunhao.th@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox