From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrei Matei <andreimatei1@gmail.com>,
bpf@vger.kernel.org, andrii.nakryiko@gmail.com
Cc: sunhao.th@gmail.com, kernel-team@dataexmachina.dev
Subject: Re: [PATCH bpf v3 1/3] bpf: add some comments to stack representation
Date: Mon, 04 Dec 2023 20:25:40 +0200 [thread overview]
Message-ID: <f62ef0d3c2a1fd6683b811d6ae974aa9b08557cc.camel@gmail.com> (raw)
In-Reply-To: <20231202230558.1648708-2-andreimatei1@gmail.com>
On Sat, 2023-12-02 at 18:05 -0500, Andrei Matei wrote:
> Signed-off-by: Andrei Matei <andreimatei1@gmail.com>
> ---
[...]
> int allocated_stack;
> + /* The state of the stack. Each element of the array describes BPF_REG_SIZE
> + * (i.e. 8) bytes worth of stack memory.
> + * stack[0] represents bytes [*(r10-8)..*(r10-1)]
> + * stack[1] represents bytes [*(r10-16)..*(r10-9)]
> + * ...
> + * stack[allocated_stack/8 - 1] represents [*(r10-allocated_size)..*(r10-allocated_size+7)]
> + */
Nit: this uses variable 'allocated_size' that does not seem defined.
Otherwise a nice comment, thanks.
next prev parent reply other threads:[~2023-12-04 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 23:05 [PATCH bpf v3 0/3] bpf: fix accesses to uninit stack slots Andrei Matei
2023-12-02 23:05 ` [PATCH bpf v3 1/3] bpf: add some comments to stack representation Andrei Matei
2023-12-04 18:18 ` Andrii Nakryiko
2023-12-04 18:25 ` Eduard Zingerman [this message]
2023-12-02 23:05 ` [PATCH bpf v3 2/3] bpf: fix accesses to uninit stack slots Andrei Matei
2023-12-02 23:09 ` Andrei Matei
2023-12-03 13:22 ` Eduard Zingerman
2023-12-04 18:19 ` Andrii Nakryiko
2023-12-02 23:05 ` [PATCH bpf v3 3/3] bpf: minor cleanup around stack bounds Andrei Matei
2023-12-04 18:19 ` Andrii Nakryiko
2023-12-04 18:43 ` Eduard Zingerman
2023-12-04 19:06 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f62ef0d3c2a1fd6683b811d6ae974aa9b08557cc.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andreimatei1@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@dataexmachina.dev \
--cc=sunhao.th@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox