From: "Shahab Vahedi" <list+bpf@vahedi.org>
To: "Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
"Hardevsinh Palaniya" <hardevsinh.palaniya@siliconsignals.io>,
ast@kernel.org, andrii@kernel.org
Cc: "Daniel Borkmann" <daniel@iogearbox.net>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"Vineet Gupta" <vgupta@kernel.org>,
bpf@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check
Date: Wed, 13 Nov 2024 02:11:54 +0000 [thread overview]
Message-ID: <6454497ff35d2a534cd34b7635fb044e4033fe6b@vahedi.org> (raw)
In-Reply-To: <e6d27adb-151c-46c1-9668-1cd2b492321b@linux.dev>
Vadim Fedorenko wrote:
> The original code is obviously optimized out, but the intention, I
> believe, was to check if the jump is conditional or not.
> So the proper fix should change the code to check cond:
>
> - if (ARC_CC_AL)
> + if (cond == ARC_CC_AL)
That is absolutely correct. If a new patch is not submitted soon
I'll try to fix it myself.
Cheers,
Shahab
next prev parent reply other threads:[~2024-11-13 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 14:19 [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check Hardevsinh Palaniya
2024-11-11 16:21 ` Vadim Fedorenko
2024-11-13 2:11 ` Shahab Vahedi [this message]
2024-11-13 5:13 ` Hardevsinh Palaniya
2024-11-13 8:03 ` Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6454497ff35d2a534cd34b7635fb044e4033fe6b@vahedi.org \
--to=list+bpf@vahedi.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vgupta@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox