From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@pm.me>
Cc: bpf@vger.kernel.org, andrii@kernel.org, ast@kernel.org,
daniel@iogearbox.net, mykolal@fb.com, bjorn@kernel.org
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: set vpath in Makefile to search for skels
Date: Tue, 17 Sep 2024 10:53:03 -0700 [thread overview]
Message-ID: <66f06b3323d17ddff2534649306be9f86aa60b5b.camel@gmail.com> (raw)
In-Reply-To: <p_YHaXjA1ci8khO7PzqJph62Huednrj7sb4zUJLrAaLUuZin6wKAJoqSl2Z32FIJs05h7FdiFHK1t4tkUem1J1ZEuD_99APjQ8zKlfOZNjs=@pm.me>
On Tue, 2024-09-17 at 15:04 +0000, Ihor Solodrai wrote:
[...]
> Eduard, I've just tried on master (without this patch)
>
> $ touch progs/verifier_and.c; make -j test_progs
>
> and I get a similar sequence:
>
> CLNG-BPF [test_progs] verifier_and.bpf.o
> GEN-SKEL [test_progs] verifier_and.skel.h
> CLNG-BPF [test_progs-cpuv4] verifier_and.bpf.o
> GEN-SKEL [test_progs-cpuv4] verifier_and.skel.h
> CLNG-BPF [test_progs-no_alu32] verifier_and.bpf.o
> GEN-SKEL [test_progs-no_alu32] verifier_and.skel.h
> TEST-OBJ [test_progs] verifier.test.o
> BINARY test_progs
> TEST-OBJ [test_progs-no_alu32] verifier.test.o
> EXT-COPY [test_progs-no_alu32] urandom_read bpf_testmod.ko bpf_test_no_cfi.ko liburandom_read.so xdp_synproxy sign-file uprobe_multi ima_setup.sh verify_sig_setup.sh btf_dump_test_case_bitfields.c btf_dump_test_case_multidim.c btf_dump_test_case_namespacing.c btf_dump_test_case_ordering.c btf_dump_test_case_packing.c btf_dump_test_case_padding.c btf_dump_test_case_syntax.c
> BINARY test_progs-no_alu32
> TEST-OBJ [test_progs-cpuv4] verifier.test.o
> EXT-COPY [test_progs-cpuv4] urandom_read bpf_testmod.ko bpf_test_no_cfi.ko liburandom_read.so xdp_synproxy sign-file uprobe_multi ima_setup.sh verify_sig_setup.sh btf_dump_test_case_bitfields.c btf_dump_test_case_multidim.c btf_dump_test_case_namespacing.c btf_dump_test_case_ordering.c btf_dump_test_case_packing.c btf_dump_test_case_padding.c btf_dump_test_case_syntax.c
> BINARY test_progs-cpuv4
>
>
> %.bpf.o -> %.skel.h -> %.test.o have to be built for each TRUNNER,
> right? And then each TRUNNER needs to be rebuilt because of %.test.o
> change. Using vpath for skels doesn't change this behavior.
>
> Maybe I'm missing something, let me know.
>
Hm, right, sorry for the noise.
next prev parent reply other threads:[~2024-09-17 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 19:59 [PATCH bpf-next 1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS Ihor Solodrai
2024-09-16 19:59 ` [PATCH bpf-next 2/2] selftests/bpf: set vpath in Makefile to search for skels Ihor Solodrai
2024-09-16 20:11 ` Ihor Solodrai
2024-09-17 4:00 ` Eduard Zingerman
2024-09-17 15:04 ` Ihor Solodrai
2024-09-17 17:53 ` Eduard Zingerman [this message]
2024-09-17 8:53 ` Björn Töpel
2024-09-17 8:50 ` [PATCH bpf-next 1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS Björn Töpel
2024-09-24 6:20 ` patchwork-bot+netdevbpf
2024-11-04 16:31 ` Matthieu Baerts
2024-11-06 22:06 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66f06b3323d17ddff2534649306be9f86aa60b5b.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ihor.solodrai@pm.me \
--cc=mykolal@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox