Re: [PATCH bpf-next 1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS

[Matthieu Baerts <matttbe@kernel.org>]

Hi Andrii,

(+cc Geliang who reported me the issue)

On 24/09/2024 08:20, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This series was applied to bpf/bpf-next.git (master)
> by Andrii Nakryiko <andrii@kernel.org>:
> 
> On Mon, 16 Sep 2024 19:59:22 +0000 you wrote:
>> test_skb_cgroup_id.sh was deleted in
>> https://git.kernel.org/bpf/bpf-next/c/f957c230e173
>>
>> It has to be removed from TEST_PROGS variable in
>> tools/testing/selftests/bpf/Makefile, otherwise install target fails.
>>
>> Link:
>> https://lore.kernel.org/bpf/Q3BN2kW9Kgy6LkrDOwnyY4Pv7_YF8fInLCd2_QA3LimKYM3wD64kRdnwp7blwG2dI_s7UGnfUae-4_dOmuTrxpYCi32G_KTzB3PfmxIerH8=@pm.me/

It looks like the two patches here are fixing issues that are on v6.12
as well: I'm on top of net-next, and I can see these issues. They are
fixed by these two patches that can be applied without conflicts.

In these patches, we can find references to the commits that introduced
the issues:

- Patch 1: f957c230e173 ("selftests/bpf: convert test_skb_cgroup_id_user
to test_progs")

- Patch 2: 844f7315e77a ("selftests/bpf: Use auto-dependencies for test
objects")

The two commits are in v6.12-rc1. Could it eventually be possible to
apply these two patches (with Fixes tags?) in the 'bpf' tree instead of
the 'bpf-next' one please?

> Here is the summary with links:
>   - [bpf-next,1/2] selftests/bpf: remove test_skb_cgroup_id.sh from TEST_PROGS
>     https://git.kernel.org/bpf/bpf-next/c/e4c139a63aff

Just in case, it looks like the history has been rewritten. The last ref
seems to be:

  d002b922c4d5 ("selftests/bpf: Remove test_skb_cgroup_id.sh from
TEST_PROGS")

>   - [bpf-next,2/2] selftests/bpf: set vpath in Makefile to search for skels
>     https://git.kernel.org/bpf/bpf-next/c/494c3a797257

... and:

  fd4a0e67838c ("selftests/bpf: Set vpath in Makefile to search for skels")

Thank you!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.